diff options
| author | Pedro Alves <palves@redhat.com> | 2020-06-18 21:28:29 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2020-06-18 23:12:43 +0100 |
| commit | 60db1b8565060f4bd2287b060ea9724c93289982 (patch) | |
| tree | 1467ab522b791b2ea7cbc581adcebfb477bf09bd /gdb | |
| parent | fe7d6a8db01f2a71520578267df7cd2d780ececb (diff) | |
| download | gdb-60db1b8565060f4bd2287b060ea9724c93289982.zip gdb-60db1b8565060f4bd2287b060ea9724c93289982.tar.gz gdb-60db1b8565060f4bd2287b060ea9724c93289982.tar.bz2 | |
Don't write to inferior_ptid in corelow.c
gdb/ChangeLog:
2020-06-18 Pedro Alves <palves@redhat.com>
* corelow.c (core_target::close): Use switch_to_no_thread instead
of writing to inferior_ptid directly.
(add_to_thread_list, core_target_open): Use switch_to_thread
instead of writing to inferior_ptid directly.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 7 | ||||
| -rw-r--r-- | gdb/corelow.c | 20 |
2 files changed, 16 insertions, 11 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4d98772..96335cb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2020-06-18 Pedro Alves <palves@redhat.com> + * corelow.c (core_target::close): Use switch_to_no_thread instead + of writing to inferior_ptid directly. + (add_to_thread_list, core_target_open): Use switch_to_thread + instead of writing to inferior_ptid directly. + +2020-06-18 Pedro Alves <palves@redhat.com> + * darwin-nat.c (darwin_nat_target::decode_message): Don't write to inferior_ptid. (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid diff --git a/gdb/corelow.c b/gdb/corelow.c index b600104..b6a12c0 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -160,8 +160,8 @@ core_target::close () { if (core_bfd) { - inferior_ptid = null_ptid; /* Avoid confusion from thread - stuff. */ + switch_to_no_thread (); /* Avoid confusion from thread + stuff. */ exit_inferior_silent (current_inferior ()); /* Clear out solib state while the bfd is still open. See @@ -182,7 +182,6 @@ core_target::close () static void add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg) { - ptid_t ptid; int core_tid; int pid, lwpid; asection *reg_sect = (asection *) reg_sect_arg; @@ -210,15 +209,15 @@ add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg) inf->fake_pid_p = fake_pid_p; } - ptid = ptid_t (pid, lwpid, 0); + ptid_t ptid (pid, lwpid); - add_thread (inf->process_target (), ptid); + thread_info *thr = add_thread (inf->process_target (), ptid); /* Warning, Will Robinson, looking at BFD private data! */ if (reg_sect != NULL && asect->filepos == reg_sect->filepos) /* Did we find .reg? */ - inferior_ptid = ptid; /* Yes, make it current. */ + switch_to_thread (thr); /* Yes, make it current. */ } /* Issue a message saying we have no core to debug, if FROM_TTY. */ @@ -339,7 +338,7 @@ core_target_open (const char *arg, int from_tty) push_target (std::move (target_holder)); - inferior_ptid = null_ptid; + switch_to_no_thread (); /* Need to flush the register cache (and the frame cache) from a previous debug session. If inferior_ptid ends up the same as the @@ -368,11 +367,10 @@ core_target_open (const char *arg, int from_tty) if (thread == NULL) { inferior_appeared (current_inferior (), CORELOW_PID); - inferior_ptid = ptid_t (CORELOW_PID); - add_thread_silent (target, inferior_ptid); + thread = add_thread_silent (target, ptid_t (CORELOW_PID)); } - else - switch_to_thread (thread); + + switch_to_thread (thread); } if (exec_bfd == nullptr) |