diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2017-01-23 15:31:40 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2017-01-23 15:31:40 -0500 |
| commit | 60685cd0b99c575a32c3d004b4af568dd0309bcb (patch) | |
| tree | 8907aebf3841495e8fcb6bf276ab4fe1ee9212c6 /gdb | |
| parent | 2d0ca824112f269a883cd04d344614ccab3baaf4 (diff) | |
| download | gdb-60685cd0b99c575a32c3d004b4af568dd0309bcb.zip gdb-60685cd0b99c575a32c3d004b4af568dd0309bcb.tar.gz gdb-60685cd0b99c575a32c3d004b4af568dd0309bcb.tar.bz2 | |
Minor simplification of (Python) find_thread_object
Since the reference to the Inferior Python object is managed by
gdbpy_ref (RAII), we can return directly from the loop. It's just a
leftover from the cleanups era.
gdb/ChangeLog:
* python/py-inferior.c (find_thread_object): Return directly
from the loop. Remove "found" variable.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/python/py-inferior.c | 9 |
2 files changed, 6 insertions, 8 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c2f7654..8704fb0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-01-23 Simon Marchi <simon.marchi@polymtl.ca> + + * python/py-inferior.c (find_thread_object): Return directly + from the loop. Remove "found" variable. + 2017-01-21 Joel Brobecker <brobecker@adacore.com> GDB 7.12.1 released. diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index 9e10d62..b2aaf25 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -251,7 +251,6 @@ find_thread_object (ptid_t ptid) { int pid; struct threadlist_entry *thread; - thread_object *found = NULL; pid = ptid_get_pid (ptid); if (pid == 0) @@ -264,13 +263,7 @@ find_thread_object (ptid_t ptid) for (thread = ((inferior_object *)(inf_obj.get ()))->threads; thread; thread = thread->next) if (ptid_equal (thread->thread_obj->thread->ptid, ptid)) - { - found = thread->thread_obj; - break; - } - - if (found) - return found; + return thread->thread_obj; return NULL; } |