diff options
| author | Christian Biesinger <cbiesinger@google.com> | 2019-10-22 14:58:45 -0500 |
|---|---|---|
| committer | Christian Biesinger <cbiesinger@google.com> | 2019-10-22 15:36:37 -0500 |
| commit | 403772ef6112b909826f8d7446fb4ceaf6f98a1e (patch) | |
| tree | 221677461276cc18f5f9fb7c345175cb8fa94a57 /gdb | |
| parent | 3a49427939764f53e196ae10013c72fcffb8c085 (diff) | |
| download | gdb-403772ef6112b909826f8d7446fb4ceaf6f98a1e.zip gdb-403772ef6112b909826f8d7446fb4ceaf6f98a1e.tar.gz gdb-403772ef6112b909826f8d7446fb4ceaf6f98a1e.tar.bz2 | |
Make demangled_name_entry::language not a bitfield
Having it as a bitfield causes extra work, and this is not memory-sensitive.
Furthermore, once https://sourceware.org/ml/gdb-patches/2019-10/msg00812.html
lands, the bitfield won't even save any memory at all.
gdb/ChangeLog:
2019-10-22 Christian Biesinger <cbiesinger@google.com>
* symtab.c (struct demangled_name_entry) <language>: Change from
bitfield to regular variable.
Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/symtab.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8255a85..9cd38a3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-10-22 Christian Biesinger <cbiesinger@google.com> + * symtab.c (struct demangled_name_entry) <language>: Change from + bitfield to regular variable. + +2019-10-22 Christian Biesinger <cbiesinger@google.com> + * symtab.c (struct demangled_name_entry): Add a constructor. (free_demangled_name_entry): New function to call the destructor for demangled_name_entry. diff --git a/gdb/symtab.c b/gdb/symtab.c index ed55cec..0a87fec 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -719,7 +719,7 @@ struct demangled_name_entry : mangled (mangled_name) {} gdb::string_view mangled; - ENUM_BITFIELD(language) language : LANGUAGE_BITS; + enum language language; char demangled[1]; }; |