aboutsummaryrefslogtreecommitdiff
path: root/gdb/unittests/scoped_mmap-selftests.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@polymtl.ca>2021-07-22 15:33:42 -0400
committerSimon Marchi <simon.marchi@polymtl.ca>2021-09-30 15:21:48 -0400
commit2fed9db40b1179f62c6fb0f2cacfb0db6b50af46 (patch)
treed47c517c106ec8bc88b6733d2b26f54f50dfec7c /gdb/unittests/scoped_mmap-selftests.c
parent13084383e8955c2ff7017ac8839301688a9ee34d (diff)
downloadgdb-2fed9db40b1179f62c6fb0f2cacfb0db6b50af46.zip
gdb-2fed9db40b1179f62c6fb0f2cacfb0db6b50af46.tar.gz
gdb-2fed9db40b1179f62c6fb0f2cacfb0db6b50af46.tar.bz2
gdbsupport: make gdb_mkostemp_cloexec return a scoped_fd
This encourages the callers to use automatic file descriptor management. Change-Id: I137a81df6f3607b457e28c35aafde8ed6f3a3344
Diffstat (limited to 'gdb/unittests/scoped_mmap-selftests.c')
-rw-r--r--gdb/unittests/scoped_mmap-selftests.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/gdb/unittests/scoped_mmap-selftests.c b/gdb/unittests/scoped_mmap-selftests.c
index 92a821d..76d6c41 100644
--- a/gdb/unittests/scoped_mmap-selftests.c
+++ b/gdb/unittests/scoped_mmap-selftests.c
@@ -89,11 +89,12 @@ static void
test_normal ()
{
char filename[] = "scoped_mmapped_file-selftest-XXXXXX";
- int fd = gdb_mkostemp_cloexec (filename);
- SELF_CHECK (fd >= 0);
+ {
+ scoped_fd fd = gdb_mkostemp_cloexec (filename);
+ SELF_CHECK (fd.get () >= 0);
- SELF_CHECK (write (fd, "Hello!", 7) == 7);
- close (fd);
+ SELF_CHECK (write (fd.get (), "Hello!", 7) == 7);
+ }
gdb::unlinker unlink_test_file (filename);