aboutsummaryrefslogtreecommitdiff
path: root/gdb/ui-style.c
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2020-09-15 08:38:22 -0600
committerTom Tromey <tromey@adacore.com>2020-09-15 08:38:22 -0600
commitdb92ac4568f1d4cc1a3409098d033afbe8b555f5 (patch)
tree9acf4726c5541a4702d58f6af0da8c747e403c8d /gdb/ui-style.c
parent7e30b1ebbf2fcf5e6bcfc3a7791d9a52614dcc43 (diff)
downloadgdb-db92ac4568f1d4cc1a3409098d033afbe8b555f5.zip
gdb-db92ac4568f1d4cc1a3409098d033afbe8b555f5.tar.gz
gdb-db92ac4568f1d4cc1a3409098d033afbe8b555f5.tar.bz2
Use arrays rather than pointers for global string constants
My understanding is that it's mildly better to use a static const array, as opposed to a "const char *", for a global string constant, when possible. This makes sense to me because the pointer requires a load from an address, whereas the array is just the address. So, I searched for these in gdb and gdbserver. This patch fixes the ones I found. gdb/ChangeLog 2020-09-15 Tom Tromey <tromey@adacore.com> * unittests/memory-map-selftests.c (valid_mem_map): Now array. * ui-style.c (ansi_regex_text): Now array. * rust-exp.y (number_regex_text): Now array. * linespec.c (linespec_quote_characters): Now array. * jit.c (jit_break_name, jit_descriptor_name, reader_init_fn_sym): Now arrays. gdbserver/ChangeLog 2020-09-15 Tom Tromey <tromey@adacore.com> * linux-x86-low.cc (xmltarget_i386_linux_no_xml) (xmltarget_amd64_linux_no_xml): Now arrays.
Diffstat (limited to 'gdb/ui-style.c')
-rw-r--r--gdb/ui-style.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/ui-style.c b/gdb/ui-style.c
index 2d6640b..4ed08da 100644
--- a/gdb/ui-style.c
+++ b/gdb/ui-style.c
@@ -23,7 +23,7 @@
/* A regular expression that is used for matching ANSI terminal escape
sequences. */
-static const char *ansi_regex_text =
+static const char ansi_regex_text[] =
/* Introduction. */
"^\033\\["
#define DATA_SUBEXP 1