aboutsummaryrefslogtreecommitdiff
path: root/gdb/tui
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2023-11-13 21:22:50 +0100
committerTom de Vries <tdevries@suse.de>2023-11-13 21:22:50 +0100
commit70911fd87f261d3726fea4699a4ffdd5623482b7 (patch)
tree6b06748001671adbc5cd5c768c2f95d935900452 /gdb/tui
parent284c40cb7dc72756e60b8754f719ba56370350a4 (diff)
downloadgdb-70911fd87f261d3726fea4699a4ffdd5623482b7.zip
gdb-70911fd87f261d3726fea4699a4ffdd5623482b7.tar.gz
gdb-70911fd87f261d3726fea4699a4ffdd5623482b7.tar.bz2
[gdb/tui] Refactor prefresh call in tui_source_window_base::refresh_window
Currently the call to prefresh in tui_source_window_base::refresh_window looks like: ... prefresh (m_pad.get (), 0, pad_x, y + 1, x + left_margin, y + m_content.size (), x + left_margin + view_width - 1); ... This is hard to parse. It's not obvious what the arguments mean, and there's repetition in the argument calculation. Fix this by rewriting the call as follows: - use sminrow, smincol, smaxrow and smaxcol variables for the last 4 arguments, and - calculate the smaxrow and smaxcol variables based on the sminrow and smincol variables. Tested on x86_64-linux. Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/tui')
-rw-r--r--gdb/tui/tui-winsource.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index dd85765..7eabc52 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -347,8 +347,11 @@ tui_source_window_base::refresh_window ()
gdb_assert (pad_width > 0 || m_pad.get () == nullptr);
gdb_assert (pad_x + view_width <= pad_width || m_pad.get () == nullptr);
- prefresh (m_pad.get (), 0, pad_x, y + 1, x + left_margin,
- y + m_content.size (), x + left_margin + view_width - 1);
+ int sminrow = y + 1;
+ int smincol = x + left_margin;
+ int smaxrow = sminrow + m_content.size () - 1;
+ int smaxcol = smincol + view_width - 1;
+ prefresh (m_pad.get (), 0, pad_x, sminrow, smincol, smaxrow, smaxcol);
}
void