aboutsummaryrefslogtreecommitdiff
path: root/gdb/tui/tui-io.c
diff options
context:
space:
mode:
authorGary Benson <gbenson@redhat.com>2014-08-04 14:03:21 +0100
committerGary Benson <gbenson@redhat.com>2014-08-29 10:12:01 +0100
commite0e6bcab5971ea4ad7c4f2efa5c8164c8383caf6 (patch)
tree59b15b72cc16e3c746e7990d63086b0fb2145f38 /gdb/tui/tui-io.c
parent0d2f5c0791fda17ebbc503c5e7716fcb619318fc (diff)
downloadgdb-e0e6bcab5971ea4ad7c4f2efa5c8164c8383caf6.zip
gdb-e0e6bcab5971ea4ad7c4f2efa5c8164c8383caf6.tar.gz
gdb-e0e6bcab5971ea4ad7c4f2efa5c8164c8383caf6.tar.bz2
Replace hardwired error handlers in tui_initialize_io
tui_initialize_io contains a pair of hardwired fprintf/exit error handlers. I was unable to find any documentation as to why they're hardwired (the code appeared in a monolithic block back in 2001: https://sourceware.org/ml/gdb-patches/2001-07/msg00490.html) and I was also unable to come up with a situation where error would not be suitable, so I have replaced both handlers with calls to error. gdb/ChangeLog: * tui/tui-io.c (tui_initialize_io): Replace two fprintf/exit pairs with calls to error. Wrap the message with _().
Diffstat (limited to 'gdb/tui/tui-io.c')
-rw-r--r--gdb/tui/tui-io.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c
index a890678..601d278 100644
--- a/gdb/tui/tui-io.c
+++ b/gdb/tui/tui-io.c
@@ -616,16 +616,12 @@ tui_initialize_io (void)
readline output in a pipe, read that pipe and output the content
in the curses command window. */
if (gdb_pipe_cloexec (tui_readline_pipe) != 0)
- {
- fprintf_unfiltered (gdb_stderr, "Cannot create pipe for readline");
- exit (1);
- }
+ error (_("Cannot create pipe for readline"));
+
tui_rl_outstream = fdopen (tui_readline_pipe[1], "w");
if (tui_rl_outstream == 0)
- {
- fprintf_unfiltered (gdb_stderr, "Cannot redirect readline output");
- exit (1);
- }
+ error (_("Cannot redirect readline output"));
+
setvbuf (tui_rl_outstream, (char*) NULL, _IOLBF, 0);
#ifdef O_NONBLOCK