diff options
author | Tom de Vries <tdevries@suse.de> | 2022-06-13 17:20:07 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2022-06-13 17:20:07 +0200 |
commit | c722093960edc1291df0a19ab0136fdb8934bdc2 (patch) | |
tree | 3d8e0be94feb80be3bc720e89225d1ee441ca846 /gdb/regcache.c | |
parent | 208b57e53ed98106d20c7314e88d0a7225a8aa1d (diff) | |
download | gdb-c722093960edc1291df0a19ab0136fdb8934bdc2.zip gdb-c722093960edc1291df0a19ab0136fdb8934bdc2.tar.gz gdb-c722093960edc1291df0a19ab0136fdb8934bdc2.tar.bz2 |
[gdb] Avoid warnings in cooked_{read,write}_test for m68hc11
With --enable-targets=all we have:
...
$ gdb -q -batch -ex "maint selftest"
...
Running selftest regcache::cooked_read_test::m68hc11.
warning: No frame soft register found in the symbol table.
Stack backtrace will not work.
Running selftest regcache::cooked_read_test::m68hc12.
warning: No frame soft register found in the symbol table.
Stack backtrace will not work.
Running selftest regcache::cooked_read_test::m68hc12:HCS12.
warning: No frame soft register found in the symbol table.
Stack backtrace will not work.
...
Likewise for regcache::cooked_write_test.
The warning has no use in the selftest context.
Fix this by skipping the specific selftests.
Tested on x86_64-linux.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29224
Diffstat (limited to 'gdb/regcache.c')
-rw-r--r-- | gdb/regcache.c | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/gdb/regcache.c b/gdb/regcache.c index 037659e..6fd4f86 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -1812,12 +1812,34 @@ public: {} }; +/* Return true if regcache::cooked_{read,write}_test should be skipped for + GDBARCH. */ + +static bool +selftest_skiparch (struct gdbarch *gdbarch) +{ + const char *name = gdbarch_bfd_arch_info (gdbarch)->printable_name; + + /* Avoid warning: + Running selftest regcache::cooked_{read,write}_test::m68hc11. + warning: No frame soft register found in the symbol table. + Stack backtrace will not work. + We could instead capture the output and then filter out the warning, but + that seems more trouble than it's worth. */ + return (strcmp (name, "m68hc11") == 0 + || strcmp (name, "m68hc12") == 0 + || strcmp (name, "m68hc12:HCS12") == 0); +} + /* Test regcache::cooked_read gets registers from raw registers and memory instead of target to_{fetch,store}_registers. */ static void cooked_read_test (struct gdbarch *gdbarch) { + if (selftest_skiparch (gdbarch)) + return; + scoped_mock_context<target_ops_no_register> mockctx (gdbarch); /* Test that read one raw register from regcache_no_target will go @@ -1944,6 +1966,9 @@ cooked_read_test (struct gdbarch *gdbarch) static void cooked_write_test (struct gdbarch *gdbarch) { + if (selftest_skiparch (gdbarch)) + return; + /* Create a mock environment. A process_stratum target pushed. */ scoped_mock_context<target_ops_no_register> ctx (gdbarch); readwrite_regcache readwrite (&ctx.mock_target, gdbarch); |