diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2023-12-01 11:27:15 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2023-12-14 16:04:49 +0000 |
| commit | e4e20d45110d919a5a2da2db84806f315ab59d90 (patch) | |
| tree | c153a7c86e48bbb61850d2dd0f230bef3ba8e9ae /gdb/nat | |
| parent | c3a03de70fd373c0f8fc4ba5df1c0db29445112c (diff) | |
| download | gdb-e4e20d45110d919a5a2da2db84806f315ab59d90.zip gdb-e4e20d45110d919a5a2da2db84806f315ab59d90.tar.gz gdb-e4e20d45110d919a5a2da2db84806f315ab59d90.tar.bz2 | |
gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h
Right now, gdbsupport/common-regcache.h contains two abstractons for a
regcache. An opaque type `regcache` (gdb and gdbserver both have their
own regcache that is the concrete version of this) and an abstract base
class `reg_buffer_common`, that is the base of regcaches on both sides.
These abstractions allow code to be written for both gdb and gdbserver,
for instance in the gdb/arch sub-directory.
However, having two
different abstractions is impractical. If some common code has a regcache,
and wants to use an operation defined on reg_buffer_common, it can't.
It would be better to have just one. Change all instances of `regcache
*` in gdbsupport/common-regcache.h to be `reg_buffer_common *`, then fix
fallouts.
Implementations in gdb and gdbserver now need to down-cast (using
gdb::checked_static_cast) from reg_buffer_common to their concrete
regcache type. Some of them could be avoided by changing free functions
(like regcache_register_size) to be virtual methods on
reg_buffer_common. I tried it, it seems to work, but I did not include
it in this series to avoid adding unnecessary changes.
Change-Id: Ia5503adb6b5509a0f4604bd2a68b4642cc5283fd
Reviewed-by: John Baldwin <jhb@FreeBSD.org>
Diffstat (limited to 'gdb/nat')
| -rw-r--r-- | gdb/nat/aarch64-hw-point.c | 3 | ||||
| -rw-r--r-- | gdb/nat/linux-btrace.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/gdb/nat/aarch64-hw-point.c b/gdb/nat/aarch64-hw-point.c index 6747e61..8e9a532 100644 --- a/gdb/nat/aarch64-hw-point.c +++ b/gdb/nat/aarch64-hw-point.c @@ -137,8 +137,7 @@ aarch64_point_is_aligned (ptid_t ptid, int is_watchpoint, CORE_ADDR addr, alignment = AARCH64_HWP_ALIGNMENT; else { - struct regcache *regcache - = get_thread_regcache_for_ptid (ptid); + reg_buffer_common *regcache = get_thread_regcache_for_ptid (ptid); /* Set alignment to 2 only if the current process is 32-bit, since thumb instruction can be 2-byte aligned. Otherwise, set diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c index 89bf28b..c4f4cbd 100644 --- a/gdb/nat/linux-btrace.c +++ b/gdb/nat/linux-btrace.c @@ -284,13 +284,12 @@ perf_event_read_bts (btrace_target_info *tinfo, const uint8_t *begin, struct perf_event_sample sample; size_t read = 0; struct btrace_block block = { 0, 0 }; - struct regcache *regcache; gdb_assert (begin <= start); gdb_assert (start <= end); /* The first block ends at the current pc. */ - regcache = get_thread_regcache_for_ptid (tinfo->ptid); + reg_buffer_common *regcache = get_thread_regcache_for_ptid (tinfo->ptid); block.end = regcache_read_pc (regcache); /* The buffer may contain a partial record as its last entry (i.e. when the |