diff options
| author | Pedro Alves <pedro@palves.net> | 2022-10-17 17:12:20 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2022-10-19 15:32:36 +0100 |
| commit | f34652de0b68c4ee3050828b43a2839b852b5821 (patch) | |
| tree | 851720f14f2ac022c3e82428254edf161d619e91 /gdb/mi | |
| parent | 5c831a3c7f3ca98d6aba1200353311e1a1f84c70 (diff) | |
| download | gdb-f34652de0b68c4ee3050828b43a2839b852b5821.zip gdb-f34652de0b68c4ee3050828b43a2839b852b5821.tar.gz gdb-f34652de0b68c4ee3050828b43a2839b852b5821.tar.bz2 | |
internal_error: remove need to pass __FILE__/__LINE__
Currently, every internal_error call must be passed __FILE__/__LINE__
explicitly, like:
internal_error (__FILE__, __LINE__, "foo %d", var);
The need to pass in explicit __FILE__/__LINE__ is there probably
because the function predates widespread and portable variadic macros
availability. We can use variadic macros nowadays, and in fact, we
already use them in several places, including the related
gdb_assert_not_reached.
So this patch renames the internal_error function to something else,
and then reimplements internal_error as a variadic macro that expands
__FILE__/__LINE__ itself.
The result is that we now should call internal_error like so:
internal_error ("foo %d", var);
Likewise for internal_warning.
The patch adjusts all calls sites. 99% of the adjustments were done
with a perl/sed script.
The non-mechanical changes are in gdbsupport/errors.h,
gdbsupport/gdb_assert.h, and gdb/gdbarch.py.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Change-Id: Ia6f372c11550ca876829e8fd85048f4502bdcf06
Diffstat (limited to 'gdb/mi')
| -rw-r--r-- | gdb/mi/mi-cmd-stack.c | 3 | ||||
| -rw-r--r-- | gdb/mi/mi-getopt.c | 3 | ||||
| -rw-r--r-- | gdb/mi/mi-out.c | 4 |
3 files changed, 4 insertions, 6 deletions
diff --git a/gdb/mi/mi-cmd-stack.c b/gdb/mi/mi-cmd-stack.c index 78688d5..f0af7c9 100644 --- a/gdb/mi/mi-cmd-stack.c +++ b/gdb/mi/mi-cmd-stack.c @@ -591,8 +591,7 @@ list_args_or_locals (const frame_print_options &fp_opts, name_of_result = "variables"; break; default: - internal_error (__FILE__, __LINE__, - "unexpected what_to_list: %d", (int) what); + internal_error ("unexpected what_to_list: %d", (int) what); } ui_out_emit_list list_emitter (uiout, name_of_result); diff --git a/gdb/mi/mi-getopt.c b/gdb/mi/mi-getopt.c index 8c08216..50c53a0 100644 --- a/gdb/mi/mi-getopt.c +++ b/gdb/mi/mi-getopt.c @@ -33,8 +33,7 @@ mi_getopt_1 (const char *prefix, int argc, char **argv, /* We assume that argv/argc are ok. */ if (*oind > argc || *oind < 0) - internal_error (__FILE__, __LINE__, - _("mi_getopt_long: oind out of bounds")); + internal_error (_("mi_getopt_long: oind out of bounds")); if (*oind == argc) return -1; arg = argv[*oind]; diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c index 96a847e..028c005 100644 --- a/gdb/mi/mi-out.c +++ b/gdb/mi/mi-out.c @@ -225,7 +225,7 @@ mi_ui_out::open (const char *name, ui_out_type type) break; default: - internal_error (__FILE__, __LINE__, _("bad switch")); + internal_error (_("bad switch")); } } @@ -245,7 +245,7 @@ mi_ui_out::close (ui_out_type type) break; default: - internal_error (__FILE__, __LINE__, _("bad switch")); + internal_error (_("bad switch")); } m_suppress_field_separator = false; |