diff options
| author | Tom Tromey <tom@tromey.com> | 2020-03-04 16:34:49 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2020-03-04 16:34:49 -0700 |
| commit | be1e3d3eab0af2a140463757a1ba3977167551af (patch) | |
| tree | 585dd9c3355bd4af81c0aa4a4439450ed3932a44 /gdb/elfread.c | |
| parent | 4e7625fde223fd0c98f09f41fe924e7317a82e1a (diff) | |
| download | gdb-be1e3d3eab0af2a140463757a1ba3977167551af.zip gdb-be1e3d3eab0af2a140463757a1ba3977167551af.tar.gz gdb-be1e3d3eab0af2a140463757a1ba3977167551af.tar.bz2 | |
Introduce objfile::intern
This introduces a string cache on the per-BFD object, replacing the
macro and filename caches. Both of these caches just store strings,
so this consolidation by itself saves a little memory (about the size
of a bcache per objfile).
Then this patch switches some allocations on the objfile obstack to
use this bcache instead. This saves more space; and turns out to be a
bit faster as well.
Here are the before and after "maint time" + "maint space" results of
"file ./gdb":
Command execution time: 4.664021 (cpu), 4.728518 (wall)
Space used: 39190528 (+29212672 for this command)
Command execution time: 4.216209 (cpu), 4.107023 (wall)
Space used: 36667392 (+26689536 for this command)
The main interface to the string cache is a new pair of overloaded
methods, objfile::intern.
gdb/ChangeLog
2020-03-04 Tom Tromey <tom@tromey.com>
* symmisc.c (print_symbol_bcache_statistics)
(print_objfile_statistics): Update.
* symfile.c (allocate_symtab): Use intern.
* psymtab.c (partial_symtab::partial_symtab): Use intern.
* objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
macro_cache>: Remove.
<string_cache>: New member.
(struct objfile) <intern>: New methods.
* elfread.c (elf_symtab_read): Use intern.
* dwarf2/read.c (fixup_go_packaging): Intern package name.
(dwarf2_compute_name, dwarf2_physname)
(create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
names.
(guess_partial_die_structure_name): Update.
(partial_die_info::fixup): Intern name.
(dwarf2_canonicalize_name): Change parameter to objfile. Intern
name.
(dwarf2_name): Intern name. Update.
* buildsym.c (buildsym_compunit::get_macro_table): Use
string_cache.
Diffstat (limited to 'gdb/elfread.c')
| -rw-r--r-- | gdb/elfread.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/gdb/elfread.c b/gdb/elfread.c index d842d5b..42c4e77 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -355,11 +355,7 @@ elf_symtab_read (minimal_symbol_reader &reader, if (type == ST_DYNAMIC && !stripped) continue; if (sym->flags & BSF_FILE) - { - filesymname - = ((const char *) objfile->per_bfd->filename_cache.insert - (sym->name, strlen (sym->name) + 1)); - } + filesymname = objfile->intern (sym->name); else if (sym->flags & BSF_SECTION_SYM) continue; else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK |