aboutsummaryrefslogtreecommitdiff
path: root/gdb/contrib
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2019-12-05 07:53:32 -0700
committerTom Tromey <tromey@adacore.com>2019-12-13 15:15:30 -0700
commita15a95ed265962027c7a8e0269bead6e5795006f (patch)
tree10b5a4cbfb329e3ba5324467efd61ef61cc65b45 /gdb/contrib
parenta5513db2f5513e84d52f77b8d9de484738ae5abe (diff)
downloadgdb-a15a95ed265962027c7a8e0269bead6e5795006f.zip
gdb-a15a95ed265962027c7a8e0269bead6e5795006f.tar.gz
gdb-a15a95ed265962027c7a8e0269bead6e5795006f.tar.bz2
Remove "boolean" and "var_boolean" checks from ARI
The "boolean" and "var_boolean" checks from ARI seem only to generate false reports. Now that gdb is in C++, at least the "boolean" check seems unlikely to ever generate a true report. The "var_boolean" check likewise doesn't seem valuable any more -- presumably this refers to some ancient way of doing things in gdb, and isn't likely to find a bug in the future. Therefore, this patch removes these two checks. gdb/ChangeLog 2019-12-13 Tom Tromey <tromey@adacore.com> * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean" checks. Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67
Diffstat (limited to 'gdb/contrib')
-rwxr-xr-xgdb/contrib/ari/gdb_ari.sh26
1 files changed, 0 insertions, 26 deletions
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 7202563..ee9f16a 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -1110,18 +1110,6 @@ Do not use strnicmp(), instead use strncasecmp()"
fail("strnicmp")
}
-# Boolean expressions and conditionals
-
-BEGIN { doc["boolean"] = "\
-Do not use `boolean'\'', use `bool'\'' instead"
- category["boolean"] = ari_regression
-}
-/(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
- if (is_yacc_or_lex == 0) {
- fail("boolean")
- }
-}
-
# Typedefs that are either redundant or can be reduced to `struct
# type *''.
# Must be placed before if assignment otherwise ARI exceptions
@@ -1143,20 +1131,6 @@ Do not use strlen dirent.d_name, instead use NAMELEN"
fail("strlen d_name")
}
-BEGIN { doc["var_boolean"] = "\
-Replace var_boolean with add_setshow_boolean_cmd"
- category["var_boolean"] = ari_regression
- fix("var_boolean", "gdb/command.h", 1)
- # fix only uses the last directory level
- fix("var_boolean", "cli/cli-decode.c", 2)
-}
-/(^|[^_[:alnum:]])var_boolean([^_[:alnum:]]|$)/ {
- if (($0 !~ /(^|[^_[:alnum:]])case *var_boolean:/) \
- && ($0 !~ /(^|[^_[:alnum:]])[=!]= *var_boolean/)) {
- fail("var_boolean")
- }
-}
-
BEGIN { doc["generic_use_struct_convention"] = "\
Replace generic_use_struct_convention with nothing, \
EXTRACT_STRUCT_VALUE_ADDRESS is a predicate"