diff options
| author | Tom Tromey <tromey@adacore.com> | 2023-03-22 13:43:03 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2023-03-27 08:37:14 -0600 |
| commit | 72a8f763233c11052b8b7eee5d2d8fb23e118c97 (patch) | |
| tree | 3435935b42e9be3fe4efd09bf111102b877295e0 /gdb/compile | |
| parent | 7005080802d695d112530a7c24c9d3d44ee109a3 (diff) | |
| download | gdb-72a8f763233c11052b8b7eee5d2d8fb23e118c97.zip gdb-72a8f763233c11052b8b7eee5d2d8fb23e118c97.tar.gz gdb-72a8f763233c11052b8b7eee5d2d8fb23e118c97.tar.bz2 | |
Change symbol::line to unsigned int
A user here at AdaCore noticed that, when debugging a certain program,
a stack frame reported line 34358, where it should have been line
99894.
After debugging a bit, I discovered:
(top) p (99894 & ~65536)
$60 = 34358
That line, symbol::line is too narrow.
This patch widens the member and changes all the uses that currently
use the narrower type.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diffstat (limited to 'gdb/compile')
| -rw-r--r-- | gdb/compile/compile-c-symbols.c | 2 | ||||
| -rw-r--r-- | gdb/compile/compile-cplus-symbols.c | 2 | ||||
| -rw-r--r-- | gdb/compile/compile-cplus-types.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/gdb/compile/compile-c-symbols.c b/gdb/compile/compile-c-symbols.c index 0449c37..e21689d 100644 --- a/gdb/compile/compile-c-symbols.c +++ b/gdb/compile/compile-c-symbols.c @@ -58,7 +58,7 @@ convert_one_symbol (compile_c_instance *context, { gcc_type sym_type; const char *filename = sym.symbol->symtab ()->filename; - unsigned short line = sym.symbol->line (); + unsigned int line = sym.symbol->line (); context->error_symbol_once (sym.symbol); diff --git a/gdb/compile/compile-cplus-symbols.c b/gdb/compile/compile-cplus-symbols.c index 5e504ac..ab18e63 100644 --- a/gdb/compile/compile-cplus-symbols.c +++ b/gdb/compile/compile-cplus-symbols.c @@ -49,7 +49,7 @@ convert_one_symbol (compile_cplus_instance *instance, /* Squash compiler warning. */ gcc_type sym_type = 0; const char *filename = sym.symbol->symtab ()->filename; - unsigned short line = sym.symbol->line (); + unsigned int line = sym.symbol->line (); instance->error_symbol_once (sym.symbol); diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c index 47cb267..02cd381 100644 --- a/gdb/compile/compile-cplus-types.c +++ b/gdb/compile/compile-cplus-types.c @@ -802,7 +802,7 @@ compile_cplus_convert_struct_or_union (compile_cplus_instance *instance, enum gcc_cp_symbol_kind nested_access) { const char *filename = nullptr; - unsigned short line = 0; + unsigned int line = 0; /* Get the decl name of this type. */ gdb::unique_xmalloc_ptr<char> name |