diff options
| author | Tom Tromey <tom@tromey.com> | 2017-11-22 20:17:28 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2017-12-08 10:23:43 -0700 |
| commit | 8e481c3ba86e512b39b16b41de24e87a17f7d968 (patch) | |
| tree | bfad22d6b383d85c5b82aa4356af50c81e7bd959 /gdb/ax-gdb.h | |
| parent | 10af2a65c8891435d0d63411a3e694cc74c9447c (diff) | |
| download | gdb-8e481c3ba86e512b39b16b41de24e87a17f7d968.zip gdb-8e481c3ba86e512b39b16b41de24e87a17f7d968.tar.gz gdb-8e481c3ba86e512b39b16b41de24e87a17f7d968.tar.bz2 | |
C++-ify parse_format_string
This replaces parse_format_string with a class, removing some
constructors along the way. While doing this, I found that one
argument to gen_printf is unused, so I removed it.
Also, I am not completely sure, but the use of `release' in
maint_agent_printf_command and parse_cmd_to_aexpr seems like it may
leak expressions.
Regression tested by the buildbot.
ChangeLog
2017-12-08 Tom Tromey <tom@tromey.com>
* printcmd.c (ui_printf): Update. Use std::vector.
* common/format.h (struct format_piece): Add constructor.
<string>: Now const.
(class format_pieces): New class.
(parse_format_string, free_format_pieces)
(free_format_pieces_cleanup): Remove.
* common/format.c (format_pieces::format_pieces): Rename from
parse_format_string. Update.
(free_format_pieces, free_format_pieces_cleanup): Remove.
* breakpoint.c (parse_cmd_to_aexpr): Update. Use std::vector.
* ax-gdb.h (gen_printf): Remove argument.
* ax-gdb.c (gen_printf): Remove "frags" argument.
(maint_agent_printf_command): Update. Use std::vector.
gdbserver/ChangeLog
2017-12-08 Tom Tromey <tom@tromey.com>
* ax.c (ax_printf): Update.
Diffstat (limited to 'gdb/ax-gdb.h')
| -rw-r--r-- | gdb/ax-gdb.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/gdb/ax-gdb.h b/gdb/ax-gdb.h index 8b5ab46..834ddff 100644 --- a/gdb/ax-gdb.h +++ b/gdb/ax-gdb.h @@ -120,10 +120,8 @@ extern void gen_expr (struct expression *exp, union exp_element **pc, extern void require_rvalue (struct agent_expr *ax, struct axs_value *value); -struct format_piece; extern agent_expr_up gen_printf (CORE_ADDR, struct gdbarch *, CORE_ADDR, LONGEST, const char *, int, - struct format_piece *, int, struct expression **); #endif /* AX_GDB_H */ |