diff options
| author | Clément Chigot <clement.chigot@atos.net> | 2021-07-27 14:37:50 +0200 |
|---|---|---|
| committer | Clément Chigot <clement.chigot@atos.net> | 2021-07-29 10:55:22 +0200 |
| commit | cd026728f3bcba878293f9c38f8760512755ed73 (patch) | |
| tree | c4ae58abb4e2179b87a068f35b94b4afccf4f099 /gas/symbols.c | |
| parent | ad42014be254b402f7a44e578cc709fe9e30dc1d (diff) | |
| download | gdb-cd026728f3bcba878293f9c38f8760512755ed73.zip gdb-cd026728f3bcba878293f9c38f8760512755ed73.tar.gz gdb-cd026728f3bcba878293f9c38f8760512755ed73.tar.bz2 | |
gas: improve C_BSTAT and C_STSYM symbols handling on XCOFF
A C_BSTAT debug symbol specifies the beginning of a static block.
Its n_value is the index of the csect containing static symbols.
A C_STSYM debug symbol represents the stabstring of a statically
allocated symbol. Its n_value is the offset in the csect pointed
by the containing C_BSTAT.
These two special n_value were not correctly handled both when
generating object files with gas or when reading them with objdump.
This patch tries to improve that and, above all, to allow gas-generated
object files with such symbols to be accepted by AIX ld.
bfd/
* coff-bfd.c (bfd_coff_get_syment): Adjust n_value of symbols
having fix_value = 1 in order to be an index and not a memory
offset.
* coffgen.c (coff_get_symbol_info): Likewize.
(coff_print_symbol): Likewize.
gas/
* config/tc-ppc.c (ppc_frob_label): Don't change within if
already set.
(ppc_stabx): Remove workaround changing exp.X_add_symbol's
within.
* config/tc-ppc.h (struct ppc_tc_sy): Update comments.
* symbols.c (resolve_symbol_value): Remove symbol update
when final_val is 0 and it's an AIX debug symbol.
* testsuite/gas/ppc/aix.exp: Add new tests.
* testsuite/gas/ppc/xcoff-stsym-32.d: New test.
* testsuite/gas/ppc/xcoff-stsym-64.d: New test.
* testsuite/gas/ppc/xcoff-stsym.s: New test.
Diffstat (limited to 'gas/symbols.c')
| -rw-r--r-- | gas/symbols.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/gas/symbols.c b/gas/symbols.c index 1221680..302eb4b 100644 --- a/gas/symbols.c +++ b/gas/symbols.c @@ -1380,7 +1380,17 @@ resolve_symbol_value (symbolS *symp) && add_symbol->flags.resolving) break; - if (finalize_syms && final_val == 0) + if (finalize_syms && final_val == 0 +#ifdef OBJ_XCOFF + /* Avoid changing symp's "within" when dealing with + AIX debug symbols. For some storage classes, "within" + have a special meaning. + C_DWARF should behave like on Linux, thus this check + isn't done to be closer. */ + && ((symbol_get_bfdsym (symp)->flags & BSF_DEBUGGING) == 0 + || (S_GET_STORAGE_CLASS (symp) == C_DWARF)) +#endif + ) { if (add_symbol->flags.local_symbol) add_symbol = local_symbol_convert (add_symbol); |