gas dwarf2dbg.c tidy

Make it a little more obvious that remap_debug_filename returns an
allocated string (that should be freed) by returning a char * rather
than const char *.  Free a few missed cases in dwarf2dbg.c, and free
other memory allocated in dwarf2dbg.c.  Also remove static
initialisation of variables and initialise in dwarf2_init instead,
in order to ensure gas state is saner for oss-fuzz.

	* remap.c (remap_debug_filename): Remove const from return.
	* as.h (remap_debug_filename): Update prototype.
	* config/obj-elf.c (obj_elf_ident): Simplify free of
	remap_debug_filename output.
	* stabs.c (stabs_generate_asm_file): Likewise.
	* dwarf2dbg.c (dirs, dirs_in_use, dirs_allocated, current): Don't
	initialise statically..
	(dwarf2_init): ..do so here, along with most other static vars.
	(assign_file_to_slot): Don't set files_allocated until we
	succeed in allocating memory.
	(purge_generated_debug): Add bool param, free more stuff if true.
	(dwarf2_directive_filename): Adjust purge_generated_debug call.
	(process_entries): Don't free line_entry here..
	(dwarf2_cleanup): ..do so here instead, new function.
	(dwarf2_finish): Call dwarf2_cleanup.  When chaining together
	subseg line entries, unhook entries from old subseg list.
	(dwarf2_directive_loc): Free remap_debug_filename string.
	(out_dir_and_file_list): Likewise.
	(out_debug_str): Likewise.

1 files changed, 2 insertions, 2 deletions

diff --git a/gas/stabs.c b/gas/stabs.c
index 5cd3c57..e80015a 100644
--- a/gas/stabs.c
+++ b/gas/stabs.c
@@ -494,14 +494,14 @@ stabs_generate_asm_file (void)
   file = as_where (&lineno);
   if (use_gnu_debug_info_extensions)
     {
-      const char *dir;
+      char *dir;
       char *dir2;
 
       dir = remap_debug_filename (getpwd ());
       dir2 = concat (dir, "/", NULL);
       generate_asm_file (N_SO, dir2);
       free (dir2);
-      xfree ((char *) dir);
+      free (dir);
     }
   generate_asm_file (N_SO, file);
 }