aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2021-06-11 14:06:47 +0930
committerAlan Modra <amodra@gmail.com>2021-06-11 14:06:47 +0930
commitf64b9b13ce4bb927f47a1fe0257c3794c6357c8c (patch)
tree241f0a0b457807eb8e4ec179728e38899087ebe5 /bfd
parent860cc54cd40334ec8709529f01e42fb4ac50b54f (diff)
downloadgdb-f64b9b13ce4bb927f47a1fe0257c3794c6357c8c.zip
gdb-f64b9b13ce4bb927f47a1fe0257c3794c6357c8c.tar.gz
gdb-f64b9b13ce4bb927f47a1fe0257c3794c6357c8c.tar.bz2
PR27952, Disallow ET_DYN DF_1_PIE linker input
This patch adds a new elf_tdata flag, is_pie, set during the linker's open_input_bfds processing. The flag is then used to reject attempts to link a PIE as if it were a shared library. bfd/ PR 27952 * elf-bfd.h (struct elf_obj_tdata): Add is_pie. * elflink.c (elf_link_add_object_symbols): Set is_pie. ld/ PR 27952 * ldelf.c (ldelf_after_open): Error on input PIEs too.
Diffstat (limited to 'bfd')
-rw-r--r--bfd/ChangeLog6
-rw-r--r--bfd/elf-bfd.h3
-rw-r--r--bfd/elflink.c2
3 files changed, 11 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index d1a92dc..ad63f9c 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2021-06-11 Alan Modra <amodra@gmail.com>
+
+ PR 27952
+ * elf-bfd.h (struct elf_obj_tdata): Add is_pie.
+ * elflink.c (elf_link_add_object_symbols): Set is_pie.
+
2021-06-09 Nick Clifton <nickc@redhat.com>
PR 27666
diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index 92b1722..8f985ab 100644
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -2080,6 +2080,9 @@ struct elf_obj_tdata
symbols. */
unsigned int bad_symtab : 1;
+ /* Set if DT_FLAGS_1 has DF_1_PIE set. */
+ unsigned int is_pie : 1;
+
/* Information grabbed from an elf core file. */
struct core_elf_obj_tdata *core;
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 0e1871a..c9a6e78 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -4349,6 +4349,8 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info)
unsigned int tagv = dyn.d_un.d_val;
audit = bfd_elf_string_from_elf_section (abfd, shlink, tagv);
}
+ if (dyn.d_tag == DT_FLAGS_1)
+ elf_tdata (abfd)->is_pie = (dyn.d_un.d_val & DF_1_PIE) != 0;
}
free (dynbuf);