diff options
| author | Nick Clifton <nickc@redhat.com> | 2015-02-27 15:38:32 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2015-02-27 15:40:49 +0000 |
| commit | cdb602b17548eeebb5e700c507d734ea5f887a49 (patch) | |
| tree | 5544597374d050c85e22c8a1f9ebc728768d9a41 /bfd | |
| parent | 6f98576f29a70ed947f102015df0388bccc6aa1a (diff) | |
| download | gdb-cdb602b17548eeebb5e700c507d734ea5f887a49.zip gdb-cdb602b17548eeebb5e700c507d734ea5f887a49.tar.gz gdb-cdb602b17548eeebb5e700c507d734ea5f887a49.tar.bz2 | |
Fixes a problem recognizing libraries created by Visual Studio.
PR binutils/17910
* coffgen.c (_bfd_coff_internal_syment_name): Only check for
string length overflow when the string table length is actually
set.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/coffgen.c | 5 |
2 files changed, 11 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index dea16ae..1b223f9 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2015-02-27 Nick Clifton <nickc@redhat.com> + + PR binutils/17910 + * coffgen.c (_bfd_coff_internal_syment_name): Only check for + string length overflow when the string table length is actually + set. + 2015-02-27 Marcus Shawcroft <marcus.shawcroft@arm.com> * bfd/bfd-in2.h: Regenerate. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index aa01559..83673d4 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -468,7 +468,10 @@ _bfd_coff_internal_syment_name (bfd *abfd, if (strings == NULL) return NULL; } - if (sym->_n._n_n._n_offset >= obj_coff_strings_len (abfd)) + /* PR 17910: Only check for string overflow if the length has been set. + Some DLLs, eg those produced by Visual Studio, may not set the length field. */ + if (obj_coff_strings_len (abfd) > 0 + && sym->_n._n_n._n_offset >= obj_coff_strings_len (abfd)) return NULL; return strings + sym->_n._n_n._n_offset; } |