diff options
| author | Alan Modra <amodra@gmail.com> | 2023-08-28 20:53:02 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2023-08-28 22:05:29 +0930 |
| commit | 54d57acf610e5db2e70afa234fd4018207606774 (patch) | |
| tree | dfdb3768a27a1a53b33651a0d398efb5f9f557ce /bfd | |
| parent | f5362c933e2280398d7aea3cc0748bec8f66a1ab (diff) | |
| download | gdb-54d57acf610e5db2e70afa234fd4018207606774.zip gdb-54d57acf610e5db2e70afa234fd4018207606774.tar.gz gdb-54d57acf610e5db2e70afa234fd4018207606774.tar.bz2 | |
Re: comdat_hash memory leaks
I missed another field that needs freeing. Also, oss-fuzz found a
case with a C_FILE sym using multiple auxents for a long file name
which overflowed the single auxent buffer. I'm going to fix that
problem in swap_aux_in too, but we may as well avoid it here too,
saving unnecessary work.
* coffcode.h (comdat_delf): Free comdat_name.
(fill_comdat_hash): Only look at symbols with one auxent.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/coffcode.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bfd/coffcode.h b/bfd/coffcode.h index 03c1788..908dc93 100644 --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -872,6 +872,7 @@ static void comdat_delf (void *ent) { struct comdat_hash_entry *e = ent; + free (e->comdat_name); free (e->symname); free (e); } @@ -964,7 +965,7 @@ fill_comdat_hash (bfd *abfd) if (*slot == NULL) { - if (isym.n_numaux == 0) + if (isym.n_numaux != 1) aux.x_scn.x_comdat = 0; else { |