diff options
| author | Alan Modra <amodra@gmail.com> | 2024-03-28 19:25:42 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-04-02 10:32:04 +1030 |
| commit | af969b14aedcc0ae27dcefab4327ff2d153dec8b (patch) | |
| tree | 0798575242610edd85068427a07f486ee5750660 /bfd/elf32-sh.c | |
| parent | f37f8c46c2e876a524301d6916a04cf7debb6483 (diff) | |
| download | gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.zip gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.gz gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.bz2 | |
PR 30569, always call elf_backend_size_dynamic_sections
This largely mechanical patch is preparation for a followup patch.
For quite some time I've thought that it would be useful to call
elf_backend_size_dynamic_sections even when no dynamic objects are
seen by the linker. That's what this patch does, with some renaming.
There are no functional changes to the linker, just a move of the
dynobj test in bfd_elf_size_dynamic_sections to target backend
functions, replacing the asserts/aborts already there. No doubt some
of the current always_size_sections functions could be moved to
size_dynamic_sections but I haven't made that change.
Because both hooks are now always called, I have renamed
always_size_sections to early_size_sections and size_dynamic_sections
to late_size_sections. I condisdered calling late_size_sections plain
size_sections, since this is the usual target dynamic section sizing
hook, but decided that searching the sources for "size_sections" would
then hit early_size_sections and other functions.
Diffstat (limited to 'bfd/elf32-sh.c')
| -rw-r--r-- | bfd/elf32-sh.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c index bf4cb2a..ecb46bb 100644 --- a/bfd/elf32-sh.c +++ b/bfd/elf32-sh.c @@ -2927,7 +2927,7 @@ allocate_dynrelocs (struct elf_link_hash_entry *h, void *inf) It's a convenient place to determine the PLT style. */ static bool -sh_elf_always_size_sections (bfd *output_bfd, struct bfd_link_info *info) +sh_elf_early_size_sections (bfd *output_bfd, struct bfd_link_info *info) { sh_elf_hash_table (info)->plt_info = get_plt_info (output_bfd, bfd_link_pic (info)); @@ -2942,8 +2942,8 @@ sh_elf_always_size_sections (bfd *output_bfd, struct bfd_link_info *info) /* Set the sizes of the dynamic sections. */ static bool -sh_elf_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED, - struct bfd_link_info *info) +sh_elf_late_size_sections (bfd *output_bfd ATTRIBUTE_UNUSED, + struct bfd_link_info *info) { struct elf_sh_link_hash_table *htab; bfd *dynobj; @@ -2956,7 +2956,8 @@ sh_elf_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED, return false; dynobj = htab->root.dynobj; - BFD_ASSERT (dynobj != NULL); + if (dynobj == NULL) + return true; if (htab->root.dynamic_sections_created) { @@ -6598,10 +6599,8 @@ sh_elf_encode_eh_address (bfd *abfd, sh_elf_link_hash_table_create #define elf_backend_adjust_dynamic_symbol \ sh_elf_adjust_dynamic_symbol -#define elf_backend_always_size_sections \ - sh_elf_always_size_sections -#define elf_backend_size_dynamic_sections \ - sh_elf_size_dynamic_sections +#define elf_backend_early_size_sections sh_elf_early_size_sections +#define elf_backend_late_size_sections sh_elf_late_size_sections #define elf_backend_omit_section_dynsym sh_elf_omit_section_dynsym #define elf_backend_finish_dynamic_symbol \ sh_elf_finish_dynamic_symbol |