aboutsummaryrefslogtreecommitdiff
path: root/bfd/coffgen.c
diff options
context:
space:
mode:
authorClément Chigot <clement.chigot@atos.net>2021-07-27 14:37:50 +0200
committerClément Chigot <clement.chigot@atos.net>2021-07-29 10:55:22 +0200
commitcd026728f3bcba878293f9c38f8760512755ed73 (patch)
treec4ae58abb4e2179b87a068f35b94b4afccf4f099 /bfd/coffgen.c
parentad42014be254b402f7a44e578cc709fe9e30dc1d (diff)
downloadgdb-cd026728f3bcba878293f9c38f8760512755ed73.zip
gdb-cd026728f3bcba878293f9c38f8760512755ed73.tar.gz
gdb-cd026728f3bcba878293f9c38f8760512755ed73.tar.bz2
gas: improve C_BSTAT and C_STSYM symbols handling on XCOFF
A C_BSTAT debug symbol specifies the beginning of a static block. Its n_value is the index of the csect containing static symbols. A C_STSYM debug symbol represents the stabstring of a statically allocated symbol. Its n_value is the offset in the csect pointed by the containing C_BSTAT. These two special n_value were not correctly handled both when generating object files with gas or when reading them with objdump. This patch tries to improve that and, above all, to allow gas-generated object files with such symbols to be accepted by AIX ld. bfd/ * coff-bfd.c (bfd_coff_get_syment): Adjust n_value of symbols having fix_value = 1 in order to be an index and not a memory offset. * coffgen.c (coff_get_symbol_info): Likewize. (coff_print_symbol): Likewize. gas/ * config/tc-ppc.c (ppc_frob_label): Don't change within if already set. (ppc_stabx): Remove workaround changing exp.X_add_symbol's within. * config/tc-ppc.h (struct ppc_tc_sy): Update comments. * symbols.c (resolve_symbol_value): Remove symbol update when final_val is 0 and it's an AIX debug symbol. * testsuite/gas/ppc/aix.exp: Add new tests. * testsuite/gas/ppc/xcoff-stsym-32.d: New test. * testsuite/gas/ppc/xcoff-stsym-64.d: New test. * testsuite/gas/ppc/xcoff-stsym.s: New test.
Diffstat (limited to 'bfd/coffgen.c')
-rw-r--r--bfd/coffgen.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index b13e773..017d4c3 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -2043,8 +2043,10 @@ coff_get_symbol_info (bfd *abfd, asymbol *symbol, symbol_info *ret)
if (coffsymbol (symbol)->native != NULL
&& coffsymbol (symbol)->native->fix_value
&& coffsymbol (symbol)->native->is_sym)
- ret->value = coffsymbol (symbol)->native->u.syment.n_value -
- (bfd_hostptr_t) obj_raw_syments (abfd);
+ ret->value =
+ ((coffsymbol (symbol)->native->u.syment.n_value -
+ (bfd_hostptr_t) obj_raw_syments (abfd))
+ / sizeof (combined_entry_type));
}
/* Print out information about COFF symbol. */
@@ -2092,7 +2094,8 @@ coff_print_symbol (bfd *abfd,
if (! combined->fix_value)
val = (bfd_vma) combined->u.syment.n_value;
else
- val = combined->u.syment.n_value - (bfd_hostptr_t) root;
+ val = ((combined->u.syment.n_value - (bfd_hostptr_t) root)
+ / sizeof (combined_entry_type));
fprintf (file, "(sec %2d)(fl 0x%02x)(ty %3x)(scl %3d) (nx %d) 0x",
combined->u.syment.n_scnum,