aboutsummaryrefslogtreecommitdiff
path: root/bfd/coff-tic4x.c
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2022-11-23 22:12:30 +1030
committerAlan Modra <amodra@gmail.com>2022-11-23 22:38:48 +1030
commite6b6fad2fe4d180bcd65a1e0aabc6ba763901346 (patch)
treebc1ceb0e32d8f6a15365185e2947bc6d724dd0e0 /bfd/coff-tic4x.c
parentd499fb89448c3f2e061813f12a1b63fbaa29422e (diff)
downloadgdb-e6b6fad2fe4d180bcd65a1e0aabc6ba763901346.zip
gdb-e6b6fad2fe4d180bcd65a1e0aabc6ba763901346.tar.gz
gdb-e6b6fad2fe4d180bcd65a1e0aabc6ba763901346.tar.bz2
PR22509 - Null pointer dereference on coff_slurp_reloc_table
This extends the commit 4581a1c7d304 fix to more targets, which hardens BFD a little. I think the real underlying problem was the bfd_canonicalize_reloc call in load_specific_debug_section which passed a NULL for "symbols". Fix that too. PR 22509 bfd/ * aoutx.h (swap_ext_reloc_out): Gracefully handle NULL symbols. * i386lynx.c (swap_ext_reloc_out): Likewise. * pdp11.c (pdp11_aout_swap_reloc_out): Likewise. * coff-tic30.c (reloc_processing): Likewise. * coff-tic4x.c (tic4x_reloc_processing): Likewise. * coff-tic54x.c (tic54x_reloc_processing): Likewise. * coff-z80.c (reloc_processing): Likewise. * coff-z8k.c (reloc_processing): Likewise. * ecoff.c (ecoff_slurp_reloc_table): Likewise. * som.c (som_set_reloc_info): Likewise. binutils/ * objdump.c (load_specific_debug_section): Pass syms to bfd_canonicalize_reloc.
Diffstat (limited to 'bfd/coff-tic4x.c')
-rw-r--r--bfd/coff-tic4x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/bfd/coff-tic4x.c b/bfd/coff-tic4x.c
index 02013e1..be29525 100644
--- a/bfd/coff-tic4x.c
+++ b/bfd/coff-tic4x.c
@@ -219,7 +219,7 @@ tic4x_reloc_processing (arelent *relent,
relent->address = reloc->r_vaddr;
- if (reloc->r_symndx != -1)
+ if (reloc->r_symndx != -1 && symbols != NULL)
{
if (reloc->r_symndx < 0 || reloc->r_symndx >= obj_conv_table_size (abfd))
{