aboutsummaryrefslogtreecommitdiff
path: root/bfd/archive.c
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-02-19 13:15:20 +1030
committerAlan Modra <amodra@gmail.com>2020-02-19 13:15:20 +1030
commit806470a219e84665a59fc6be632d4ed6a4ad908b (patch)
tree2d6c80034712a1dca2ef77c4926caf39a1bce949 /bfd/archive.c
parent1f4361a77b18c5ab32baf2f30fefe5e301e017be (diff)
downloadgdb-806470a219e84665a59fc6be632d4ed6a4ad908b.zip
gdb-806470a219e84665a59fc6be632d4ed6a4ad908b.tar.gz
gdb-806470a219e84665a59fc6be632d4ed6a4ad908b.tar.bz2
Miscellaneous memory alloc related fixes
Some minor tidies. Allocating memory for internal relocs and symbols after reading external relocs is slightly better with fuzzed files. You can at least do something about silly sizes that way. * aoutx.h (slurp_reloc_table): Allocate reloc_cache after reading external relocs. * ecoff.c (ecoff_slurp_reloc_table): Likewise. * archive.c (_bfd_write_archive_contents): Don't twiddle bfd_error after bfd_bread. * archive64.c (_bfd_archive_64_bit_slurp_armap): Remove unnecessary bfd_release. * elf32-m32c.c (m32c_offset_for_reloc): Make shndx_buf a bfd_byte*. (m32c_elf_relax_section): Likewise. * elf32-rl78.c (rl78_offset_for_reloc): Likewise. (rl78_elf_relax_section): Likewise. * elf32-rx.c (rx_offset_for_reloc): Likewise. (elf32_rx_relax_section): Likewise. * mach-o.c (bfd_mach_o_alloc_and_read): Move earlier with better parameter types and use.. (bfd_mach_o_read_dylinker, bfd_mach_o_read_dylib), (bfd_mach_o_read_fvmlib, bfd_mach_o_read_str): ..in these functions. * peicode.h (pe_bfd_object_p): Don't zero the part of opthdr being read from file, just the extra. * som.c (som_slurp_symbol_table): Allocate internal symbol buffer after reading external syms. Free on failure.
Diffstat (limited to 'bfd/archive.c')
-rw-r--r--bfd/archive.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/bfd/archive.c b/bfd/archive.c
index 67d1c9e..91127d7 100644
--- a/bfd/archive.c
+++ b/bfd/archive.c
@@ -2193,11 +2193,7 @@ _bfd_write_archive_contents (bfd *arch)
amt = remaining;
errno = 0;
if (bfd_bread (buffer, amt, current) != amt)
- {
- if (bfd_get_error () != bfd_error_system_call)
- bfd_set_error (bfd_error_file_truncated);
- goto input_err;
- }
+ goto input_err;
if (bfd_bwrite (buffer, amt, arch) != amt)
return FALSE;
remaining -= amt;