aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2023-04-21 07:05:53 -0600
committerTom Tromey <tromey@adacore.com>2023-04-21 09:06:03 -0600
commitda9a978aae78e2c1e35ccdf683474847e4465e5f (patch)
tree2de5193d6da7ce87dd37efbf818ccd345f4cef7e
parentfbdecfbf285234cd4eba0e7daf480c63b2d65eb3 (diff)
downloadgdb-da9a978aae78e2c1e35ccdf683474847e4465e5f.zip
gdb-da9a978aae78e2c1e35ccdf683474847e4465e5f.tar.gz
gdb-da9a978aae78e2c1e35ccdf683474847e4465e5f.tar.bz2
Fix -Wmaybe-uninitialized warning in opcodes/i386-dis.c
A recent change in opcodes/i386-dis.c caused a build failure on my x86-64 Fedora 36 system, which uses: $ gcc --version gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4) [...] The error is: ../../binutils-gdb/opcodes/i386-dis.c: In function ‘OP_J’: ../../binutils-gdb/opcodes/i386-dis.c:12705:22: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized] 12705 | disp = val & 0x8000 ? val - 0x10000 : val; | ~~~~^~~~~~~~ This patch fixes the warning. opcodes/ChangeLog 2023-04-21 Tom Tromey <tromey@adacore.com> * i386-dis.c (OP_J): Check result of get16.
-rw-r--r--opcodes/ChangeLog4
-rw-r--r--opcodes/i386-dis.c3
2 files changed, 6 insertions, 1 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index d0c338a..890931e 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@
+2023-04-21 Tom Tromey <tromey@adacore.com>
+
+ * i386-dis.c (OP_J): Check result of get16.
+
2023-04-12 Claudiu Zissulescu <claziss@synopsys.com>
* arc-tbl.h: Remove vadds2, vadds2h, vadds4h, vaddsubs,
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 46ba01f..f021bda 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -12701,7 +12701,8 @@ OP_J (instr_info *ins, int bytemode, int sizeflag)
{
int val;
- get16 (ins, &val);
+ if (!get16 (ins, &val))
+ return false;
disp = val & 0x8000 ? val - 0x10000 : val;
/* In 16bit mode, address is wrapped around at 64k within
the same segment. Otherwise, a data16 prefix on a jump