diff options
| author | Yao Qi <yao.qi@linaro.org> | 2017-11-22 12:22:11 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2017-11-22 12:22:11 +0000 |
| commit | a9f26f609e3a1b6ae3aab300b55442e0a81e2bce (patch) | |
| tree | f8eb85e7a41177838af4fa3aa1ea6c8956162025 | |
| parent | 29f9a5673764c1b2711c0ceeba380a6ee764d1b2 (diff) | |
| download | gdb-a9f26f609e3a1b6ae3aab300b55442e0a81e2bce.zip gdb-a9f26f609e3a1b6ae3aab300b55442e0a81e2bce.tar.gz gdb-a9f26f609e3a1b6ae3aab300b55442e0a81e2bce.tar.bz2 | |
Fix build with GCC 8: strncpy ->strcpy
Recent gcc 8 trunk emits the warning below,
../../binutils-gdb/gdb/python/py-gdb-readline.c:79:15: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
strncpy (q, p, n);
~~~~~~~~^~~~~~~~~
../../binutils-gdb/gdb/python/py-gdb-readline.c:73:14: note: length computed here
n = strlen (p);
~~~~~~~^~~
gdb:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy.
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/python/py-gdb-readline.c | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a9e7528..63ae72e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-11-22 Yao Qi <yao.qi@linaro.org> + * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy. + +2017-11-22 Yao Qi <yao.qi@linaro.org> + * cli/cli-decode.c (help_list): Use memcpy instead of strncpy. * cp-namespace.c (cp_lookup_transparent_type_loop): Likewise. diff --git a/gdb/python/py-gdb-readline.c b/gdb/python/py-gdb-readline.c index a02fa8c..ab14b8c 100644 --- a/gdb/python/py-gdb-readline.c +++ b/gdb/python/py-gdb-readline.c @@ -76,7 +76,7 @@ gdbpy_readline_wrapper (FILE *sys_stdin, FILE *sys_stdout, q = (char *) PyMem_RawMalloc (n + 2); if (q != NULL) { - strncpy (q, p, n); + strcpy (q, p); q[n] = '\n'; q[n + 1] = '\0'; } |