diff options
| author | Alan Modra <amodra@gmail.com> | 2021-02-11 09:53:17 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-02-11 11:58:19 +1030 |
| commit | 6db658c517bdfbf8e5b8c5a34caf3ff1eea332f1 (patch) | |
| tree | c4033214b990c8c2cc35baf32de1e1c1bba9d4d2 | |
| parent | 160fe1933736c123e15199080874fcab8b9ecc65 (diff) | |
| download | gdb-6db658c517bdfbf8e5b8c5a34caf3ff1eea332f1.zip gdb-6db658c517bdfbf8e5b8c5a34caf3ff1eea332f1.tar.gz gdb-6db658c517bdfbf8e5b8c5a34caf3ff1eea332f1.tar.bz2 | |
PR27291, integer overflow in bfd_get_section_contents
Makes the code a little more elegant too. Note that the unsigned
overflow reported here is well defined so this patch doesn't fix any
real problem.
PR 27291
* section.c (bfd_get_section_contents): Avoid possible overflow
when range checking offset and count.
(bfd_set_section_contents): Likewise.
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/section.c | 6 |
2 files changed, 9 insertions, 4 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index ebe2b58..41da87b 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2021-02-11 Alan Modra <amodra@gmail.com> + + PR 27291 + * section.c (bfd_get_section_contents): Avoid possible overflow + when range checking offset and count. + (bfd_set_section_contents): Likewise. + 2021-02-03 Nick Alcock <nick.alcock@oracle.com> * configure.ac (SHARED_LIBADD): Remove explicit -lintl population in diff --git a/bfd/section.c b/bfd/section.c index 3e6ba0c..059b6fa 100644 --- a/bfd/section.c +++ b/bfd/section.c @@ -1498,8 +1498,7 @@ bfd_set_section_contents (bfd *abfd, sz = section->size; if ((bfd_size_type) offset > sz - || count > sz - || offset + count > sz + || count > sz - offset || count != (size_t) count) { bfd_set_error (bfd_error_bad_value); @@ -1569,8 +1568,7 @@ bfd_get_section_contents (bfd *abfd, else sz = section->size; if ((bfd_size_type) offset > sz - || count > sz - || offset + count > sz + || count > sz - offset || count != (size_t) count) { bfd_set_error (bfd_error_bad_value); |