diff options
| author | Tom Tromey <tromey@adacore.com> | 2021-12-08 12:52:34 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2021-12-08 13:02:44 -0700 |
| commit | 621f8c42d3df079ca5781cdb0925c5ec3498f59c (patch) | |
| tree | ebf093da156b721c5b8690f79bd55f6017af510b | |
| parent | 2988a36005f2821cee6744473ad8a3ba7638c212 (diff) | |
| download | gdb-621f8c42d3df079ca5781cdb0925c5ec3498f59c.zip gdb-621f8c42d3df079ca5781cdb0925c5ec3498f59c.tar.gz gdb-621f8c42d3df079ca5781cdb0925c5ec3498f59c.tar.bz2 | |
Fix error in file_and_directory patch
In my earlier C++-ization patch for file_and_directory, I introduced
an error:
- if (strcmp (fnd.name, "<unknown>") != 0)
+ if (fnd.is_unknown ())
This change inverted the sense of the test, which causes failures with
.debug_names.
This patch fixes the bug. Regression tested on x86-64 Fedora 34. I
also tested it using the AdaCore internal test suite, with
.debug_names -- this was failing before, and now it works.
| -rw-r--r-- | gdb/dwarf2/read.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index f2d7da7..dd2134b 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -3008,7 +3008,7 @@ dw2_get_file_names_reader (const struct die_reader_specs *reader, file_and_directory &fnd = find_file_and_directory (comp_unit_die, cu); int offset = 0; - if (fnd.is_unknown ()) + if (!fnd.is_unknown ()) ++offset; else if (lh == nullptr) return; |