aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-03-11 14:43:16 +1030
committerAlan Modra <amodra@gmail.com>2020-03-11 16:03:35 +1030
commit2846942c7c83d007106cdcf1108ceedb50e1d4ec (patch)
tree1f7b8c5329a52da310ffc49e68725200a5404076
parentb681dd46d55a0666cb689acf0a01a9efae589978 (diff)
downloadgdb-binutils-2_32-branch.zip
gdb-binutils-2_32-branch.tar.gz
gdb-binutils-2_32-branch.tar.bz2
powerpc64-ld infinite loopbinutils-2_32-branch
If this code dealing with possible conversion of inline plt sequences is ever executed, ld will hang. A binary with such sequences and of code size larger than approximately 90% the reach of an unconditional branch is the trigger. Oops. * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop. (cherry picked from commit 435edf0bf231240ccecb474b74ebb49dc8db2633)
-rw-r--r--bfd/ChangeLog4
-rw-r--r--bfd/elf64-ppc.c2
2 files changed, 5 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 88a6914..77ed3e0 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11 Alan Modra <amodra@gmail.com>
+
+ * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
+
2020-01-15 Alan Modra <amodra@gmail.com>
PR 25384
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 9ced4f8..83832f3 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -7158,7 +7158,7 @@ ppc64_elf_inline_plt (struct bfd_link_info *info)
return FALSE;
relend = relstart + sec->reloc_count;
- for (rel = relstart; rel < relend; )
+ for (rel = relstart; rel < relend; rel++)
{
enum elf_ppc64_reloc_type r_type;
unsigned long r_symndx;