cobol: Fix incorrect use of std::remove_if

The call to std::remove_if used here doesn't remove any elements, it
just overwrites the "removed" elements with later elements, leaving the
total number of elements unchanged. Use std::list::remove_if to actually
remove those unwanted elements from the list.

gcc/cobol/ChangeLog:

	* symfind.cc (finalize_symbol_map2): Use std::list::remove_if
	instead of std::remove_if.

1 files changed, 4 insertions, 5 deletions

diff --git a/gcc/cobol/symfind.cc b/gcc/cobol/symfind.cc
index 2687fdb..8995715 100644
--- a/gcc/cobol/symfind.cc
+++ b/gcc/cobol/symfind.cc
@@ -128,11 +128,10 @@ finalize_symbol_map2() {
 
   for( auto& elem : symbol_map2 ) {
     auto& fields( elem.second );
-    std::remove_if( fields.begin(), fields.end(),
-                  []( auto isym ) {
-                    auto f = cbl_field_of(symbol_at(isym));
-                    return f->type == FldInvalid;
-                  } );
+    fields.remove_if( []( auto isym ) {
+			auto f = cbl_field_of(symbol_at(isym));
+			return f->type == FldInvalid;
+		      } );
     if( fields.empty() ) empties.insert(elem.first);
   }