diff options
| author | Nick Alcock <nick.alcock@oracle.com> | 2024-01-05 11:09:01 +0000 |
|---|---|---|
| committer | Nick Alcock <nick.alcock@oracle.com> | 2024-04-19 16:14:46 +0100 |
| commit | 4fa4e3d92ac3940305b4521aef3e58555a4aa4b5 (patch) | |
| tree | fba1ec4c5d2c39161a6099f221d77fd78029763f /libctf/ctf-serialize.c | |
| parent | b4b77b26e220c065123c455c8ed81086c8481c10 (diff) | |
| download | binutils-4fa4e3d92ac3940305b4521aef3e58555a4aa4b5.zip binutils-4fa4e3d92ac3940305b4521aef3e58555a4aa4b5.tar.gz binutils-4fa4e3d92ac3940305b4521aef3e58555a4aa4b5.tar.bz2 | |
libctf: delete LCTF_DIRTY
This flag was meant as an optimization to avoid reserializing dicts
unnecessarily. It was critically necessary back when serialization was
done by ctf_update() and you had to call that every time you wanted any
new modifications to the type table to be usable by other types, but
that has been unnecessary for years now, and serialization is only done
once when writing out, which one would naturally assume would always
serialize the dict. Worse, it never really worked: it only tracked
newly-added types, not things like added symbols which might equally
well require reserialization, and it gets in the way of an upcoming
change. Delete entirely.
libctf/
* ctf-create.c (ctf_create): Drop LCTF_DIRTY.
(ctf_discard): Likewise.
(ctf_rollback): Likewise.
(ctf_add_generic): Likewise.
(ctf_set_array): Likewise.
(ctf_add_enumerator): Likewise.
(ctf_add_member_offset): Likewise.
(ctf_add_variable_forced): Likewise.
* ctf-link.c (ctf_link_intern_extern_string): Likewise.
(ctf_link_add_strtab): Likewise.
* ctf-serialize.c (ctf_serialize): Likewise.
* ctf-impl.h (LCTF_DIRTY): Likewise.
(LCTF_LINKING): Renumber.
Diffstat (limited to 'libctf/ctf-serialize.c')
| -rw-r--r-- | libctf/ctf-serialize.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/libctf/ctf-serialize.c b/libctf/ctf-serialize.c index 7092264..9dd7fbd 100644 --- a/libctf/ctf-serialize.c +++ b/libctf/ctf-serialize.c @@ -980,10 +980,6 @@ ctf_serialize (ctf_dict_t *fp) if (fp->ctf_stypes > 0) return (ctf_set_errno (fp, ECTF_RDONLY)); - /* Update required? */ - if (!(fp->ctf_flags & LCTF_DIRTY)) - return 0; - /* The strtab refs table must be empty at this stage. Any refs already added will be corrupted by any modifications, including reserialization, after strtab finalization is complete. Only this function, and functions it @@ -1156,7 +1152,6 @@ ctf_serialize (ctf_dict_t *fp) nfp->ctf_parent = fp->ctf_parent; nfp->ctf_parent_unreffed = fp->ctf_parent_unreffed; nfp->ctf_refcnt = fp->ctf_refcnt; - nfp->ctf_flags |= fp->ctf_flags & ~LCTF_DIRTY; if (nfp->ctf_dynbase == NULL) nfp->ctf_dynbase = buf; /* Make sure buf is freed on close. */ nfp->ctf_dthash = fp->ctf_dthash; |