aboutsummaryrefslogtreecommitdiff
path: root/gdbsupport
diff options
context:
space:
mode:
authorMichael Weghorn <m.weghorn@posteo.de>2020-05-25 11:40:07 -0400
committerSimon Marchi <simon.marchi@polymtl.ca>2020-05-25 11:40:35 -0400
commit7dbfcd6f79d9f66e317e61bac5855868f8d20043 (patch)
treef95c39efbfe3b5f150f93e4c7a1fe202a3b9ad9c /gdbsupport
parentbea571ebd78ee29cb94adf648fbcda1e109e1be6 (diff)
downloadbinutils-7dbfcd6f79d9f66e317e61bac5855868f8d20043.zip
binutils-7dbfcd6f79d9f66e317e61bac5855868f8d20043.tar.gz
binutils-7dbfcd6f79d9f66e317e61bac5855868f8d20043.tar.bz2
gdbsupport: Drop now unused function 'stringify_argv'
The function did not properly escape special characters and all uses have been replaced in previous commits, so drop the now unused function. gdbsupport/ChangeLog: * common-utils.cc, common-utils.h (stringify_argv): Drop now unused function stringify_argv Change-Id: Id5f861f44eae1f0fbde3476a5eac23a842ed04fc
Diffstat (limited to 'gdbsupport')
-rw-r--r--gdbsupport/ChangeLog5
-rw-r--r--gdbsupport/common-utils.cc23
-rw-r--r--gdbsupport/common-utils.h4
3 files changed, 5 insertions, 27 deletions
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index 61b57ff..7c2c4bf 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,5 +1,10 @@
2020-05-25 Michael Weghorn <m.weghorn@posteo.de>
+ * common-utils.cc, common-utils.h (stringify_argv): Drop
+ now unused function stringify_argv
+
+2020-05-25 Michael Weghorn <m.weghorn@posteo.de>
+
* common-inferior.cc, common-inferior.h (construct_inferior_arguments):
Adapt to take a gdb::array_view<char * const> parameter.
Adapt call site.
diff --git a/gdbsupport/common-utils.cc b/gdbsupport/common-utils.cc
index ed05d61..b5e4d29 100644
--- a/gdbsupport/common-utils.cc
+++ b/gdbsupport/common-utils.cc
@@ -375,29 +375,6 @@ free_vector_argv (std::vector<char *> &v)
/* See gdbsupport/common-utils.h. */
-std::string
-stringify_argv (const std::vector<char *> &args)
-{
- std::string ret;
-
- if (!args.empty () && args[0] != NULL)
- {
- for (auto s : args)
- if (s != NULL)
- {
- ret += s;
- ret += ' ';
- }
-
- /* Erase the last whitespace. */
- ret.erase (ret.end () - 1);
- }
-
- return ret;
-}
-
-/* See gdbsupport/common-utils.h. */
-
ULONGEST
align_up (ULONGEST v, int n)
{
diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h
index ba03427..30ee412 100644
--- a/gdbsupport/common-utils.h
+++ b/gdbsupport/common-utils.h
@@ -154,10 +154,6 @@ extern const char *skip_to_space (const char *inp);
freeing all the elements. */
extern void free_vector_argv (std::vector<char *> &v);
-/* Given a vector of arguments ARGV, return a string equivalent to
- joining all the arguments with a whitespace separating them. */
-extern std::string stringify_argv (const std::vector<char *> &argv);
-
/* Return true if VALUE is in [LOW, HIGH]. */
template <typename T>