diff options
| author | Thomas Preud'homme <thomas.preudhomme@arm.com> | 2017-11-29 10:45:31 +0000 |
|---|---|---|
| committer | Thomas Preud'homme <thomas.preudhomme@arm.com> | 2017-11-29 10:45:31 +0000 |
| commit | f106e10e5e80265e1c43532bba4cb997a7dfa022 (patch) | |
| tree | 0746a8a878d5db303c516d66d08b77d52c5e88cb /gdb | |
| parent | ca39c2f4dd0fedcaaee348be7a913f0c14876796 (diff) | |
| download | binutils-f106e10e5e80265e1c43532bba4cb997a7dfa022.zip binutils-f106e10e5e80265e1c43532bba4cb997a7dfa022.tar.gz binutils-f106e10e5e80265e1c43532bba4cb997a7dfa022.tar.bz2 | |
[gdb/testsuite] Fix wrong return type in tests
The following tests are marked untested with latest GCC due to a warning
being emitted for a mismatch between their return type and what the lack
of return statement:
* gdb.cp/breakpoint.exp
* gdb.cp/psymtab-parameter.exp
* gdb.cp/shadow.exp
This patch fix the return type to match the function definitions.
2017-11-29 Thomas Preud'homme <thomas.preudhomme@arm.com>
gdb/testsuite/
* gdb.cp/breakpoint.cc (bar): Set return type to void.
* gdb.cp/psymtab-parameter.cc (func): Likewise.
* gdb.cp/psymtab-parameter.exp: Update comment regarding prototype of
func ().
* gdb.cp/shadow.cc (B.func): Return 0.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 8 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.cp/breakpoint.cc | 2 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.cp/psymtab-parameter.cc | 2 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.cp/psymtab-parameter.exp | 2 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.cp/shadow.cc | 1 |
5 files changed, 12 insertions, 3 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 16c93dc..23d3cc2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2017-11-29 Thomas Preud'homme <thomas.preudhomme@arm.com> + + * gdb.cp/breakpoint.cc (bar): Set return type to void. + * gdb.cp/psymtab-parameter.cc (func): Likewise. + * gdb.cp/psymtab-parameter.exp: Update comment regarding prototype of + func (). + * gdb.cp/shadow.cc (B.func): Return 0. + 2017-11-27 Joel Brobecker <brobecker@adacore.com> * gdb.ada/mi_catch_ex.exp (continue_to_exception): Adjust diff --git a/gdb/testsuite/gdb.cp/breakpoint.cc b/gdb/testsuite/gdb.cp/breakpoint.cc index fc9b9d9..1feff44 100644 --- a/gdb/testsuite/gdb.cp/breakpoint.cc +++ b/gdb/testsuite/gdb.cp/breakpoint.cc @@ -28,7 +28,7 @@ public: return 1; // conditional breakpoint in method } - int bar () + void bar () { for (int i = 0; i < 1; ++i) { diff --git a/gdb/testsuite/gdb.cp/psymtab-parameter.cc b/gdb/testsuite/gdb.cp/psymtab-parameter.cc index 0990430..9f63fef 100644 --- a/gdb/testsuite/gdb.cp/psymtab-parameter.cc +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.cc @@ -16,7 +16,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ template <typename T> -long +void func () { } diff --git a/gdb/testsuite/gdb.cp/psymtab-parameter.exp b/gdb/testsuite/gdb.cp/psymtab-parameter.exp index 3d78de9..5c4b6ac 100644 --- a/gdb/testsuite/gdb.cp/psymtab-parameter.exp +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.exp @@ -31,6 +31,6 @@ gdb_test_no_output "set language c++" # XFAIL than FAIL here. For example -readnow breaks it. gdb_test_no_output "maintenance info symtabs" -# GDB has shown only the `long func<short>()' ELF symbol before, not the DWARF +# GDB has shown only the `void func<short>()' ELF symbol before, not the DWARF # symbol gdb_test "complete p 'func<short>(" "p 'func<short>\\(\\)" diff --git a/gdb/testsuite/gdb.cp/shadow.cc b/gdb/testsuite/gdb.cp/shadow.cc index 0520b2a..4c9fb12 100644 --- a/gdb/testsuite/gdb.cp/shadow.cc +++ b/gdb/testsuite/gdb.cp/shadow.cc @@ -36,6 +36,7 @@ public: } } } + return 0; } }; |