diff options
author | Tom de Vries <tdevries@suse.de> | 2024-02-26 16:03:45 +0100 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2024-02-26 16:03:45 +0100 |
commit | dd88f42597e903a7847b9ffc10fee4fbbbd66cf8 (patch) | |
tree | c058eedfa0c84506e20a6eded829fbc9f1eb41cb /gdb | |
parent | d82ede20df36eb8acfc9e67969e396e3a8fe1d45 (diff) | |
download | binutils-dd88f42597e903a7847b9ffc10fee4fbbbd66cf8.zip binutils-dd88f42597e903a7847b9ffc10fee4fbbbd66cf8.tar.gz binutils-dd88f42597e903a7847b9ffc10fee4fbbbd66cf8.tar.bz2 |
[gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found
For a patch I submitted, the Linaro CI reported a failure:
...
FAIL: gdb.dap/attach.exp: exceptions in log file
...
I ran the test-case locally, and observed the same FAIL in the gdb.sum file.
I then wanted to confirm that I reproduced the exact same problem, but
realized that I couldn't because there's no way for me to know what exception
occurred, and where, because that information is logged in the dap.log.$n
file, and the Linaro CI only saves the gdb.sum and gdb.log files.
This issue is even worse if only the CI can reproduce a FAIL.
Fix this in dap_check_log_file by dumping dap.log.$n to gdb.log when
exceptions are found.
Tested on x86_64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
-rw-r--r-- | gdb/testsuite/lib/dap-support.exp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp index 72c22d0..89a4b0e 100644 --- a/gdb/testsuite/lib/dap-support.exp +++ b/gdb/testsuite/lib/dap-support.exp @@ -381,6 +381,9 @@ proc dap_check_log_file {} { if {$ok} { pass "exceptions in log file" } else { + verbose -log -- "--- DAP LOG START ---" + verbose -log -- $contents + verbose -log -- "--- DAP LOG END ---" fail "exceptions in log file" } } |