diff options
| author | Tom Tromey <tom@tromey.com> | 2021-03-08 07:27:57 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2021-03-08 07:28:43 -0700 |
| commit | ce284361a2b8c928df94acdb9afd005242140bb1 (patch) | |
| tree | 9132adb8f531b9ebf4aed26fe24904797f962741 /gdb | |
| parent | b9d06571f9d1c39edb0d3e976ff78586d7c436b0 (diff) | |
| download | binutils-ce284361a2b8c928df94acdb9afd005242140bb1.zip binutils-ce284361a2b8c928df94acdb9afd005242140bb1.tar.gz binutils-ce284361a2b8c928df94acdb9afd005242140bb1.tar.bz2 | |
Inline expr_builder methods
This inlines the expr_builder constructor and release method. These
are straightforward, so this seemed simpler.
gdb/ChangeLog
2021-03-08 Tom Tromey <tom@tromey.com>
* parser-defs.h (struct expr_builder) <expr_builder>: Inline.
<release>: Inline.
* parse.c (expr_builder::expr_builder, expr_builder::release):
Remove.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 7 | ||||
| -rw-r--r-- | gdb/parse.c | 14 | ||||
| -rw-r--r-- | gdb/parser-defs.h | 10 |
3 files changed, 15 insertions, 16 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e2f6368..212f61d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2021-03-08 Tom Tromey <tom@tromey.com> + * parser-defs.h (struct expr_builder) <expr_builder>: Inline. + <release>: Inline. + * parse.c (expr_builder::expr_builder, expr_builder::release): + Remove. + +2021-03-08 Tom Tromey <tom@tromey.com> + * parse.c (expression::expression, expression::~expression): Remove. * expression.h (struct expression): Inline constructor. Remove diff --git a/gdb/parse.c b/gdb/parse.c index d068c94..056dee1 100644 --- a/gdb/parse.c +++ b/gdb/parse.c @@ -91,20 +91,6 @@ innermost_block_tracker::update (const struct block *b, -/* See definition in parser-defs.h. */ - -expr_builder::expr_builder (const struct language_defn *lang, - struct gdbarch *gdbarch) - : expout (new expression (lang, gdbarch)) -{ -} - -expression_up -expr_builder::release () -{ - return std::move (expout); -} - /* Return the type of MSYMBOL, a minimal symbol of OBJFILE. If ADDRESS_P is not NULL, set it to the MSYMBOL's resolved address. */ diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h index 3e81e0b..2276821 100644 --- a/gdb/parser-defs.h +++ b/gdb/parser-defs.h @@ -42,13 +42,19 @@ struct expr_builder And GDBARCH is the gdbarch to use during parsing. */ expr_builder (const struct language_defn *lang, - struct gdbarch *gdbarch); + struct gdbarch *gdbarch) + : expout (new expression (lang, gdbarch)) + { + } DISABLE_COPY_AND_ASSIGN (expr_builder); /* Resize the allocated expression to the correct size, and return it as an expression_up -- passing ownership to the caller. */ - ATTRIBUTE_UNUSED_RESULT expression_up release (); + ATTRIBUTE_UNUSED_RESULT expression_up release () + { + return std::move (expout); + } /* Return the gdbarch that was passed to the constructor. */ |