diff options
| author | Tom de Vries <tdevries@suse.de> | 2023-02-20 12:20:14 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2023-02-20 12:20:14 +0100 |
| commit | cb911672fb70233f3ef127f68fc0a43d7f339a62 (patch) | |
| tree | 2233ec1e60478508cdbb7a900b198f4016c32e1f /gdb | |
| parent | 1bcaeecb7fd8a23f05033bc9a340696b685db17f (diff) | |
| download | binutils-cb911672fb70233f3ef127f68fc0a43d7f339a62.zip binutils-cb911672fb70233f3ef127f68fc0a43d7f339a62.tar.gz binutils-cb911672fb70233f3ef127f68fc0a43d7f339a62.tar.bz2 | |
[gdb/symtab] Factor out compunit_epilogue_unwind_valid
Factor out compunit_epilogue_unwind_valid from both
amd64_stack_frame_destroyed_p and i386_stack_frame_destroyed_p. No functional
changes.
Also add a comment in the new function about the assumption that in absence of
producer information, epilogue unwind info is invalid.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/amd64-tdep.c | 4 | ||||
| -rw-r--r-- | gdb/i386-tdep.c | 4 | ||||
| -rw-r--r-- | gdb/symtab.h | 13 |
3 files changed, 15 insertions, 6 deletions
diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 9ce3e37..08f906b 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -2902,10 +2902,8 @@ static int amd64_stack_frame_destroyed_p (struct gdbarch *gdbarch, CORE_ADDR pc) { gdb_byte insn; - struct compunit_symtab *cust; - cust = find_pc_compunit_symtab (pc); - if (cust != NULL && cust->epilogue_unwind_valid ()) + if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc))) return 0; if (target_read_memory (pc, &insn, 1)) diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index acf22db..19358ca 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -2219,10 +2219,8 @@ static int i386_stack_frame_destroyed_p (struct gdbarch *gdbarch, CORE_ADDR pc) { gdb_byte insn; - struct compunit_symtab *cust; - cust = find_pc_compunit_symtab (pc); - if (cust != NULL && cust->epilogue_unwind_valid ()) + if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc))) return 0; if (target_read_memory (pc, &insn, 1)) diff --git a/gdb/symtab.h b/gdb/symtab.h index 11ff875..cd6b5f7 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -1917,6 +1917,19 @@ is_main_symtab_of_compunit_symtab (struct symtab *symtab) { return symtab == symtab->compunit ()->primary_filetab (); } + +/* Return true if epilogue unwind info of CUST is valid. */ + +static inline bool +compunit_epilogue_unwind_valid (struct compunit_symtab *cust) +{ + /* In absence of producer information, assume epilogue unwind info is + invalid. */ + if (cust == nullptr) + return false; + + return cust->epilogue_unwind_valid (); +} /* The virtual function table is now an array of structures which have the |