diff options
| author | Aaron Merey <amerey@redhat.com> | 2021-11-19 19:41:40 -0500 |
|---|---|---|
| committer | Aaron Merey <amerey@redhat.com> | 2022-03-08 15:37:01 -0500 |
| commit | 9ac37a9ce607b790bea17c7782d73afecaaa916c (patch) | |
| tree | 3c532b7a4e52e42ce2417250a3bcd4e310aa238e /gdb | |
| parent | a9c82bc13cf8dd5d9076e746f744ee711eb55507 (diff) | |
| download | binutils-9ac37a9ce607b790bea17c7782d73afecaaa916c.zip binutils-9ac37a9ce607b790bea17c7782d73afecaaa916c.tar.gz binutils-9ac37a9ce607b790bea17c7782d73afecaaa916c.tar.bz2 | |
PR gdb/27876 - debuginfod-downloaded source files don't pass proper fullname across mi / (gdb)info source
Source files downloaded from debuginfod currently use their original DWARF
filename as their "fullname". This causes a mismatch between the fullname
and the actual location of the source file in the debuginfod client cache.
MI consumers such as VSCode will fail to open debuginfod-downloaded
source files due to this. Also 'info source' will fail to include the
true paths of these files.
To fix this, use the debuginfod cache path as the fullname for debuginfod-
downloaded source files.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/debuginfod-support.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c index 56d8e77..b44ce67 100644 --- a/gdb/debuginfod-support.c +++ b/gdb/debuginfod-support.c @@ -202,6 +202,7 @@ debuginfod_source_query (const unsigned char *build_id, if (c == nullptr) return scoped_fd (-ENOMEM); + char *dname = nullptr; user_data data ("source file", srcpath); debuginfod_set_user_data (c, &data); @@ -216,7 +217,7 @@ debuginfod_source_query (const unsigned char *build_id, build_id, build_id_len, srcpath, - nullptr)); + &dname)); debuginfod_set_user_data (c, nullptr); if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT) @@ -225,7 +226,7 @@ debuginfod_source_query (const unsigned char *build_id, styled_string (file_name_style.style (), srcpath)); if (fd.get () >= 0) - *destname = make_unique_xstrdup (srcpath); + destname->reset (dname); return fd; } |