diff options
| author | Tom Tromey <tromey@adacore.com> | 2024-11-20 13:29:39 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2024-12-09 13:52:54 -0700 |
| commit | 55980c88d4754460f200c3bcf229b7b8dfa42948 (patch) | |
| tree | a860a09730a3161bae61219ed10485db23306ad9 /gdb/testsuite/gdb.python/py-lazy-string.c | |
| parent | d8e96210c0c214626cb33221bf39108c626cc2ba (diff) | |
| download | binutils-55980c88d4754460f200c3bcf229b7b8dfa42948.zip binutils-55980c88d4754460f200c3bcf229b7b8dfa42948.tar.gz binutils-55980c88d4754460f200c3bcf229b7b8dfa42948.tar.bz2 | |
Allow cancellation of DAP-thread requests
This patch started as an attempt to fix the comment in
CancellationHandler.cancel, but while working on it I found that the
code could be improved as well.
The current DAP cancellation code only handles the case where work is
done on the gdb thread -- by checking for cancellation in
interruptable_region. This means that if a request is handled
completely in tthe DAP thread, then cancellation will never work.
Now, this isn't a bug per se. DAP doesn't actually require that
cancellation succeed. In fact, I think it can't, because cancellation
is inherently racy.
However, a coming patch will add a sort of "pending" request, and it
would be nice if that were cancellable before any commands are sent to
the gdb thread.
No test in this patch, but one will arrive at the end of the series.
Reviewed-by: Kévin Le Gouguec <legouguec@adacore.com>
Diffstat (limited to 'gdb/testsuite/gdb.python/py-lazy-string.c')
0 files changed, 0 insertions, 0 deletions