diff options
| author | Tom Tromey <tom@tromey.com> | 2025-12-19 07:40:05 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2025-12-22 13:24:38 -0700 |
| commit | d7bc2ad4178b753f0a406fb274a437d11771bf1b (patch) | |
| tree | 516be3cfa8f77da58a08f3bd3a924d8fbe73444a /gdb/python | |
| parent | 164b8847c408f77b747cd33e6f9b8a50f75324b8 (diff) | |
| download | binutils-d7bc2ad4178b753f0a406fb274a437d11771bf1b.tar.gz binutils-d7bc2ad4178b753f0a406fb274a437d11771bf1b.tar.bz2 binutils-d7bc2ad4178b753f0a406fb274a437d11771bf1b.zip | |
Use string_view in user_reg_map_name_to_regnum
This changes user_reg_map_name_to_regnum to use std::string_view.
This pointed out some dead code in that function: the "len < 0" test
in the loop can never be true, because earlier code changes 'len' in
this case.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diffstat (limited to 'gdb/python')
| -rw-r--r-- | gdb/python/py-registers.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/gdb/python/py-registers.c b/gdb/python/py-registers.c index a3f8357e075..fb82e164187 100644 --- a/gdb/python/py-registers.c +++ b/gdb/python/py-registers.c @@ -350,8 +350,7 @@ register_descriptor_iter_find (PyObject *self, PyObject *args, PyObject *kw) if (register_name != NULL && *register_name != '\0') { - int regnum = user_reg_map_name_to_regnum (gdbarch, register_name, - strlen (register_name)); + int regnum = user_reg_map_name_to_regnum (gdbarch, register_name); if (regnum >= 0) return gdbpy_get_register_descriptor (gdbarch, regnum).release (); } @@ -374,8 +373,7 @@ gdbpy_parse_register_id (struct gdbarch *gdbarch, PyObject *pyo_reg_id, if (reg_name != NULL) { - *reg_num = user_reg_map_name_to_regnum (gdbarch, reg_name.get (), - strlen (reg_name.get ())); + *reg_num = user_reg_map_name_to_regnum (gdbarch, reg_name.get ()); if (*reg_num >= 0) return true; PyErr_SetString (PyExc_ValueError, "Bad register"); |