diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2025-04-22 18:01:07 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2025-04-23 15:46:22 +0100 |
| commit | bd7a2f22b11e37ce35c3a78f6fb54ef74270b903 (patch) | |
| tree | 648bf05447ae30e8e12a7dfeb071499f46a64188 /gdb/python | |
| parent | dff7f6c72d05d8a378dc346e6900ba7c4eba759f (diff) | |
| download | binutils-bd7a2f22b11e37ce35c3a78f6fb54ef74270b903.zip binutils-bd7a2f22b11e37ce35c3a78f6fb54ef74270b903.tar.gz binutils-bd7a2f22b11e37ce35c3a78f6fb54ef74270b903.tar.bz2 | |
gdb/python: remove Py_TPFLAGS_BASETYPE from gdb.Color
Remove the Py_TPFLAGS_BASETYPE flag from the gdb.Color type. This
effectively makes gdb.Color final; users can no longer create classes
that inherit from gdb.Color.
Right now I cannot think of any cases where inheritance would be
needed over composition for a simple type like gdb.Color. If I'm
wrong, then it's easy to add Py_TPFLAGS_BASETYPE back in later, this
would be an extension of the API. But it's much harder to remove the
flag later as that might break existing user code (note: there has
been no release of GDB yet that includes the gdb.Color type).
Introducing this restriction makes the next commit easier.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/python')
| -rw-r--r-- | gdb/python/py-color.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/python/py-color.c b/gdb/python/py-color.c index 9e29ee2..fb4b80e 100644 --- a/gdb/python/py-color.c +++ b/gdb/python/py-color.c @@ -312,7 +312,7 @@ PyTypeObject colorpy_object_type = get_attr, /*tp_getattro*/ 0, /*tp_setattro*/ 0, /*tp_as_buffer*/ - Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE, /*tp_flags*/ + Py_TPFLAGS_DEFAULT, /*tp_flags*/ "GDB color object", /* tp_doc */ 0, /* tp_traverse */ 0, /* tp_clear */ |