diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2026-04-16 16:16:12 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2026-04-17 15:30:18 -0400 |
| commit | 85d417c37274603f5265ce67e348789e5c8417cf (patch) | |
| tree | b9228c2a007ee4c0868c4449f449a2a958e95085 /gdb/python | |
| parent | a25edafeafb13a62f220a7ff8e6072f6c27738ed (diff) | |
| download | binutils-85d417c37274603f5265ce67e348789e5c8417cf.tar.gz binutils-85d417c37274603f5265ce67e348789e5c8417cf.tar.bz2 binutils-85d417c37274603f5265ce67e348789e5c8417cf.zip | |
gdb: rename search_symtabs_expansion_listener -> compunit_symtab_iteration_callback
I think that the name search_symtabs_expansion_listener function type
no longer makes sense for the following reasons:
- Since we have both `symtab` and `compunit_symtab` structs, I like
when we are specific about which one we're talking about. In this
case, the callback takes a `compunit_symtab`.
- Following series "Search symbols via quick API" [1] last year (I
believe commit f88f9f42db8 ("Have expand_symtabs_matching work for
already-expanded CUs")), the callback gets called for all matching
compunit_symtabs, not just those that get expanded.
I therefore propose to rename it to compunit_symtab_iteration_callback.
I chose "callback" over "listener", because I think that listener
implies that there is some event happening, that we listen for. That
made sense before where we would listen for the "expansion" event. But
now since it just gets called back for all matching CUs, I think that
"callback" makes more sense.
I renamed the parameters accordingly.
[1] https://inbox.sourceware.org/gdb-patches/20250909-search-in-psyms-v4-0-e7ef9e3b6479@tromey.com/
Change-Id: Ia5a662e6d37caf8e0272424ddbbd82f05bdb5ebe
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/python')
0 files changed, 0 insertions, 0 deletions
