diff options
| author | Tom Tromey <tromey@adacore.com> | 2026-03-24 08:59:31 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2026-03-25 11:12:14 -0600 |
| commit | bbc133a3083cebcb9d2e010bef47753448d0046f (patch) | |
| tree | 26a101298156a96b7f4af076fd15bdf7d617fdfa /gdb/python/python-internal.h | |
| parent | 1a10ac99959e8d28694cb47d0632552e6feb03b2 (diff) | |
| download | binutils-bbc133a3083cebcb9d2e010bef47753448d0046f.tar.gz binutils-bbc133a3083cebcb9d2e010bef47753448d0046f.tar.bz2 binutils-bbc133a3083cebcb9d2e010bef47753448d0046f.zip | |
Hold the GIL while clearing gdbpy_reggroup_object_map
Tom de Vries pointed out that a certain Python test left a core file.
Looking into this, I think the problem is that the GIL is not held
when gdbpy_reggroup_object_map is destroyed.
This patch changes the code to explicitly clear the global while
holding the GIL. This fixed the crash for me.
This also adds a comment to gdbpy_initialize_file to explicitly
mention that the GIL is held while the finalizers are run.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34013
Reviewed-By: Tom de Vries <tdevries@suse.de>
Diffstat (limited to 'gdb/python/python-internal.h')
| -rw-r--r-- | gdb/python/python-internal.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index bdc960ed208..b24b9314994 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -616,7 +616,9 @@ class gdbpy_initialize_file There is no error return in this case. This function is only called when GDB is already shutting down. The function should make a best - effort to clean up, and then return. */ + effort to clean up, and then return. + + The GIL will be held while calling the finalizers. */ using gdbpy_finalize_file_ftype = void (*) (void); |