diff options
| author | Tom Tromey <tom@tromey.com> | 2018-05-25 12:39:51 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-05-25 12:41:02 -0600 |
| commit | d525a99be1b02dda6c69007e31dd06f276378aea (patch) | |
| tree | 1fc7017164c71811abc89b028e2fb99d87f8a33a /gdb/interps.c | |
| parent | da505cff6e29b18244dc9f6886bcb4d436263dee (diff) | |
| download | binutils-d525a99be1b02dda6c69007e31dd06f276378aea.zip binutils-d525a99be1b02dda6c69007e31dd06f276378aea.tar.gz binutils-d525a99be1b02dda6c69007e31dd06f276378aea.tar.bz2 | |
Add "name" method to class interp
In a review Pedro pointed out that interp::name is intended to be
read-only, and so an accessor would be a better fit. This patch
renames the field and adds a "name" method that is used instead.
ChangeLog
2018-05-25 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_enable): Update.
* mi/mi-interp.c (mi_interp::init): Update.
* interps.h (class interp) <name>: New method.
<m_name>: Rename from name.
(~scoped_restore_interp): Update.
* interps.c (interp::interp): Update.
(interp_add, interp_set, interp_lookup_existing)
(current_interp_named_p): Update.
Diffstat (limited to 'gdb/interps.c')
| -rw-r--r-- | gdb/interps.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/gdb/interps.c b/gdb/interps.c index 8ec9744..789ae86 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -78,8 +78,8 @@ static struct interp *interp_lookup_existing (struct ui *ui, const char *name); interp::interp (const char *name) + : m_name (xstrdup (name)) { - this->name = xstrdup (name); this->inited = false; } @@ -129,7 +129,7 @@ interp_add (struct ui *ui, struct interp *interp) { struct ui_interp_info *ui_interp = get_interp_info (ui); - gdb_assert (interp_lookup_existing (ui, interp->name) == NULL); + gdb_assert (interp_lookup_existing (ui, interp->name ()) == NULL); interp->next = ui_interp->interp_list; ui_interp->interp_list = interp; @@ -170,11 +170,11 @@ interp_set (struct interp *interp, bool top_level) /* We use interpreter_p for the "set interpreter" variable, so we need to make sure we have a malloc'ed copy for the set command to free. */ if (interpreter_p != NULL - && strcmp (interp->name, interpreter_p) != 0) + && strcmp (interp->name (), interpreter_p) != 0) { xfree (interpreter_p); - interpreter_p = xstrdup (interp->name); + interpreter_p = xstrdup (interp->name ()); } /* Run the init proc. */ @@ -206,7 +206,7 @@ interp_lookup_existing (struct ui *ui, const char *name) interp != NULL; interp = interp->next) { - if (strcmp (interp->name, name) == 0) + if (strcmp (interp->name (), name) == 0) return interp; } @@ -282,7 +282,7 @@ current_interp_named_p (const char *interp_name) struct interp *interp = ui_interp->current_interpreter; if (interp != NULL) - return (strcmp (interp->name, interp_name) == 0); + return (strcmp (interp->name (), interp_name) == 0); return 0; } |