diff options
| author | Alan Modra <amodra@gmail.com> | 2022-11-14 08:25:16 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2022-11-14 11:36:46 +1030 |
| commit | 4f5c4fce8878830d8e4e928fa0dbe3f4ee2eb2cd (patch) | |
| tree | 85d0c7efd9d38d9fb3caf11b5c1ee0e9e754183a /gas/write.c | |
| parent | f31e4e02eed3a758d757c7ede855b7aec1dd3850 (diff) | |
| download | binutils-4f5c4fce8878830d8e4e928fa0dbe3f4ee2eb2cd.zip binutils-4f5c4fce8878830d8e4e928fa0dbe3f4ee2eb2cd.tar.gz binutils-4f5c4fce8878830d8e4e928fa0dbe3f4ee2eb2cd.tar.bz2 | |
objcopy renaming section with explicit flags
This tidies SEC_RELOC handling in bfd, in the process fixing a bug
with objcopy when renaming sections.
bfd/
* reloc.c (_bfd_generic_set_reloc): Set/clear SEC_RELOC depending
on reloc count.
* elf64-sparc.c (elf64_sparc_set_reloc): Likewise.
binutils/
* objcopy.c (copy_relocations_in_section): Remove now unnecessary
clearing of SEC_RELOC.
* testsuite/binutils-all/rename-section-01.d: New test.
* testsuite/binutils-all/objcopy.exp: Run it.
gas/
* write.c (size_seg): Remove unneccesary twiddle of SEC_RELOC.
(write_relocs): Likewise. Always call bfd_set_reloc.
Diffstat (limited to 'gas/write.c')
| -rw-r--r-- | gas/write.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/gas/write.c b/gas/write.c index 1c1b810..3014f68 100644 --- a/gas/write.c +++ b/gas/write.c @@ -579,7 +579,6 @@ size_seg (bfd *abfd ATTRIBUTE_UNUSED, asection *sec, void *xxx ATTRIBUTE_UNUSED) if (size > 0 && ! seginfo->bss) flags |= SEC_HAS_CONTENTS; - flags &= ~SEC_RELOC; x = bfd_set_section_flags (sec, flags); gas_assert (x); @@ -1385,13 +1384,7 @@ write_relocs (bfd *abfd ATTRIBUTE_UNUSED, asection *sec, } #endif - if (n) - { - flagword flags = bfd_section_flags (sec); - flags |= SEC_RELOC; - bfd_set_section_flags (sec, flags); - bfd_set_reloc (stdoutput, sec, relocs, n); - } + bfd_set_reloc (stdoutput, sec, n ? relocs : NULL, n); #ifdef SET_SECTION_RELOCS SET_SECTION_RELOCS (sec, relocs, n); |