diff options
| author | Tom Tromey <tom@tromey.com> | 2022-06-12 11:36:08 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-07-08 13:56:56 -0600 |
| commit | fa17a6814113ac22d8059d61514aa2c6e29b0aae (patch) | |
| tree | 8b4349d43b605434454c9905578e472608861ffa | |
| parent | 57f8fe908bec51c40ec686294460ec979b140843 (diff) | |
| download | binutils-fa17a6814113ac22d8059d61514aa2c6e29b0aae.zip binutils-fa17a6814113ac22d8059d61514aa2c6e29b0aae.tar.gz binutils-fa17a6814113ac22d8059d61514aa2c6e29b0aae.tar.bz2 | |
Handle bool specially in gdb.set_parameter
PR python/29217 points out that gdb.parameter will return bool values,
but gdb.set_parameter will not properly accept them. This patch fixes
the problem by adding a special case to set_parameter.
I looked at a fix involving rewriting set_parameter in C++. However,
this one is simpler.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29217
| -rw-r--r-- | gdb/python/lib/gdb/__init__.py | 7 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.python/py-parameter.exp | 4 |
2 files changed, 11 insertions, 0 deletions
diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py index 17ee6a1..9e9978e 100644 --- a/gdb/python/lib/gdb/__init__.py +++ b/gdb/python/lib/gdb/__init__.py @@ -239,6 +239,13 @@ def find_pc_line(pc): def set_parameter(name, value): """Set the GDB parameter NAME to VALUE.""" + # Handle the specific case of booleans here, because gdb.parameter + # can return them, but they can't be passed to 'set' this way. + if isinstance(value, bool): + if value: + value = 'on' + else: + value = 'off' execute("set " + name + " " + str(value), to_string=True) diff --git a/gdb/testsuite/gdb.python/py-parameter.exp b/gdb/testsuite/gdb.python/py-parameter.exp index db158dd..d6db6ac 100644 --- a/gdb/testsuite/gdb.python/py-parameter.exp +++ b/gdb/testsuite/gdb.python/py-parameter.exp @@ -126,6 +126,10 @@ proc_with_prefix test_boolean_parameter { } { "The state of the Test Parameter is off.*" "show parameter off" gdb_test "python print (test_param.value)" "False" \ "test boolean parameter value is False" + gdb_test_no_output "python gdb.set_parameter('print test-param', True)" \ + "set boolean parameter using set_parameter" + gdb_test "python print(gdb.parameter('print test-param'))" "True" \ + "get boolean parameter using gdb.parameter" gdb_test "help show print test-param" \ [multi_line \ "Show the state of the boolean test-param" \ |