aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTankut Baris Aktemur <tankut.baris.aktemur@intel.com>2025-01-29 10:50:29 +0100
committerTankut Baris Aktemur <tankut.baris.aktemur@intel.com>2025-01-29 11:17:33 +0100
commitdcaf6d3f431d95dabcd27c54b7e9fb51989e3b23 (patch)
tree25d7a6746cc250b2f3487fc755da01831f16ad51
parent146d4e2acecc4c34b3c0742e55e33653614a5ca1 (diff)
downloadbinutils-dcaf6d3f431d95dabcd27c54b7e9fb51989e3b23.zip
binutils-dcaf6d3f431d95dabcd27c54b7e9fb51989e3b23.tar.gz
binutils-dcaf6d3f431d95dabcd27c54b7e9fb51989e3b23.tar.bz2
gdbserver: add back lost comments in fast_tracepoint_ctx
Before the removal of the UST/static-tracepoint support, the `static_tracepoint_ctx` struct contained comments for its fields, whereas `fast_tracepoint_ctx` did not. Nevertheless, those comments also applied to `fast_tracepoint_ctx`. With the removal of `static_tracepoint_ctx`, the comments were lost, making `fast_tracepoint_ctx` data members completely commentless. Add back those comments. Approved-By: Simon Marchi <simon.marchi@efficios.com>
-rw-r--r--gdbserver/tracepoint.cc9
1 files changed, 9 insertions, 0 deletions
diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc
index 1395c70..559d34d 100644
--- a/gdbserver/tracepoint.cc
+++ b/gdbserver/tracepoint.cc
@@ -1184,11 +1184,20 @@ struct fast_tracepoint_ctx
{
struct tracepoint_hit_ctx base;
+ /* The regcache corresponding to the registers state at the time of
+ the tracepoint hit. Initialized lazily, from REGS. */
struct regcache regcache;
int regcache_initted;
+
+ /* The buffer space REGCACHE above uses. We use a separate buffer
+ instead of letting the regcache malloc for both signal safety and
+ performance reasons; this is allocated on the stack instead. */
unsigned char *regspace;
+ /* The register buffer passed by the client. */
unsigned char *regs;
+
+ /* The GDB tracepoint matching the probed marker that was "hit". */
struct tracepoint *tpoint;
};