aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@efficios.com>2024-01-19 10:35:37 -0500
committerSimon Marchi <simon.marchi@efficios.com>2024-01-19 11:29:20 -0500
commita332b7c7d0d604f4ea6e0ff4d9119e3ec73f6079 (patch)
treef40c0099fe98199009319f9b390c4f338d97d8fd
parentc873acc5fec5623b90c9143df8d9cb8704bb97ac (diff)
downloadbinutils-a332b7c7d0d604f4ea6e0ff4d9119e3ec73f6079.zip
binutils-a332b7c7d0d604f4ea6e0ff4d9119e3ec73f6079.tar.gz
binutils-a332b7c7d0d604f4ea6e0ff4d9119e3ec73f6079.tar.bz2
gdb: remove unnecessary NULL checks for return value of value_from_register
value_from_register can't return nullptr, remove some NULL checks. Change-Id: Ia6b32b8f86e593c535e3678a89dffe5544eb7ab0 Approved-By: Tom Tromey <tom@tromey.com>
-rw-r--r--gdb/findvar.c23
1 files changed, 3 insertions, 20 deletions
diff --git a/gdb/findvar.c b/gdb/findvar.c
index d0bb3fd..37b859c 100644
--- a/gdb/findvar.c
+++ b/gdb/findvar.c
@@ -623,29 +623,12 @@ language_defn::read_var_value (struct symbol *var,
{
int regno = SYMBOL_REGISTER_OPS (var)
->register_number (var, get_frame_arch (frame));
- struct value *regval;
if (var->aclass () == LOC_REGPARM_ADDR)
- {
- regval = value_from_register (lookup_pointer_type (type),
- regno,
- frame);
-
- if (regval == NULL)
- error (_("Value of register variable not available for `%s'."),
- var->print_name ());
-
- addr = value_as_address (regval);
- }
+ addr = value_as_address
+ (value_from_register (lookup_pointer_type (type), regno, frame));
else
- {
- regval = value_from_register (type, regno, frame);
-
- if (regval == NULL)
- error (_("Value of register variable not available for `%s'."),
- var->print_name ());
- return regval;
- }
+ return value_from_register (type, regno, frame);
}
break;