aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGuinevere Larsen <guinevere@redhat.com>2024-11-07 16:15:20 -0300
committerGuinevere Larsen <guinevere@redhat.com>2024-11-08 08:59:05 -0300
commit9ebb627ed6400bafa60705a567701b2cc7774d4f (patch)
tree84aa8ac2cc9ba880388bc608ae289c05a38e5924
parent3a4653efc3f2470ac9703051f16b0185917eb1de (diff)
downloadbinutils-9ebb627ed6400bafa60705a567701b2cc7774d4f.zip
binutils-9ebb627ed6400bafa60705a567701b2cc7774d4f.tar.gz
binutils-9ebb627ed6400bafa60705a567701b2cc7774d4f.tar.bz2
gdb: make the error message for unreadable objfiles more informative
When GDB is unable to read an objfile, it prints the error message "I'm sorry Dave, I can't do that. Symbol format `%s' unknown.". While it is a great reference, an end user won't have much information about the problem. So far this wasn't much of a problem, as it is very uncommon for GDB to be unable to read an objfile. However, a future patch will allow users to selectively disable support to some formats, making it somewhat expected that the message will be seen by end users. This commit makes the end message more informative and direct. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=13299 Approved-By: Tom Tromey <tom@tromey.com>
-rw-r--r--gdb/symfile.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 1502fdb..adc60e1 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -1775,8 +1775,8 @@ find_sym_fns (bfd *abfd)
if (our_flavour == rsf.sym_flavour)
return rsf.sym_fns;
- error (_("I'm sorry, Dave, I can't do that. Symbol format `%s' unknown."),
- bfd_get_target (abfd));
+ error (_("Object file %s could not be read. Symbol format `%s' unknown."),
+ abfd->filename, bfd_get_target (abfd));
}