diff options
| author | Tom Tromey <tromey@adacore.com> | 2024-06-05 10:38:10 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2024-06-24 09:11:30 -0600 |
| commit | 979114a1b39cbcbe61faeaf9fe65ead589ea1096 (patch) | |
| tree | be3b6777a4b7aa59819a00e1efd962d6a03c7a4d | |
| parent | 9f71296fda412c315a8dde05b51d5163e3e2e53c (diff) | |
| download | binutils-979114a1b39cbcbe61faeaf9fe65ead589ea1096.zip binutils-979114a1b39cbcbe61faeaf9fe65ead589ea1096.tar.gz binutils-979114a1b39cbcbe61faeaf9fe65ead589ea1096.tar.bz2 | |
Prefer htab_traverse_noresize
A few spots in gdb were using htab_traverse. IMO this is almost never
useful and htab_traverse_noresize should be preferred.
| -rw-r--r-- | gdb/completer.c | 2 | ||||
| -rw-r--r-- | gdb/dwarf2/cu.c | 3 | ||||
| -rw-r--r-- | gdb/gdb_bfd.c | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/gdb/completer.c b/gdb/completer.c index f1f4410..bd5118f 100644 --- a/gdb/completer.c +++ b/gdb/completer.c @@ -2058,7 +2058,7 @@ completion_tracker::recompute_lowest_common_denominator () return 1; }; - htab_traverse (m_entries_hash.get (), visitor_func, this); + htab_traverse_noresize (m_entries_hash.get (), visitor_func, this); m_lowest_common_denominator_valid = true; } diff --git a/gdb/dwarf2/cu.c b/gdb/dwarf2/cu.c index aae61cc..5cb2291 100644 --- a/gdb/dwarf2/cu.c +++ b/gdb/dwarf2/cu.c @@ -146,7 +146,8 @@ dwarf2_cu::mark () { m_mark = true; if (m_dependencies != nullptr) - htab_traverse (m_dependencies.get (), dwarf2_mark_helper, per_objfile); + htab_traverse_noresize (m_dependencies.get (), dwarf2_mark_helper, + per_objfile); } } diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index cb9a91d..7e272c7 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -1200,7 +1200,7 @@ maintenance_info_bfds (const char *arg, int from_tty) uiout->table_header (40, ui_left, "filename", "Filename"); uiout->table_body (); - htab_traverse (all_bfds, print_one_bfd, uiout); + htab_traverse_noresize (all_bfds, print_one_bfd, uiout); } /* BFD related per-inferior data. */ |