diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2025-08-19 08:32:13 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2025-08-19 14:33:39 +0100 |
| commit | 56e7e4ca3b87828509156d9dd84285bf8ba004cb (patch) | |
| tree | efa661261372187d5adbbf6e4a858e5404f61d5c | |
| parent | 985bc55e998d83086c7bf9a1a71a52a2673370c7 (diff) | |
| download | binutils-56e7e4ca3b87828509156d9dd84285bf8ba004cb.zip binutils-56e7e4ca3b87828509156d9dd84285bf8ba004cb.tar.gz binutils-56e7e4ca3b87828509156d9dd84285bf8ba004cb.tar.bz2 | |
gdb/testsuite: fix invalid assumption about TUI src window
Fix a failing test introduced by this commit:
commit e53b88b40ed38651b50f954dfe76066822094c15
Date: Wed Aug 13 15:29:38 2025 +0100
gdb: fix forward/reverse search, when no lines are printed
The TUI test added in this commit assumed that the opening '{' of main
would be the first statement line (in DWARF terms), and so, would be
the initial focus of the TUI src window.
This is true for some targets (e.g. x86), but not
others (e.g. AArch64), and so gdb.tui/source-search.exp was seen
failing on at least some AArch64 targets.
Fix this by adding a 'list' command to the test, which forces the
initial window contents to be as needed for the rest of the test.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33290
Approved-By: Tom de Vries <tdevries@suse.de>
| -rw-r--r-- | gdb/testsuite/gdb.tui/source-search.exp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.tui/source-search.exp b/gdb/testsuite/gdb.tui/source-search.exp index 6865db4..41bf121 100644 --- a/gdb/testsuite/gdb.tui/source-search.exp +++ b/gdb/testsuite/gdb.tui/source-search.exp @@ -36,9 +36,10 @@ proc check_src_window { testname first_line } { } +# Initialise the src window so that it is displaying known contents. +# Check that the expected contents are displayed. +Term::command "list 20" set first_line 15 - -# Check that the window contents are as expected. check_src_window "initial src contents" $first_line # Search forward. Searches are from the last line displayed, so this |