aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2023-02-24 13:55:29 -0700
committerTom Tromey <tromey@adacore.com>2023-03-10 07:57:45 -0700
commit1cd0716eb199963ec63fcafa94699d14bbf45e01 (patch)
tree13aa4dca04b2821b4788bdb10e085ee57ae79f51
parenta4d5aec71e097837ee314eca612f71a3d85b6b3f (diff)
downloadbinutils-1cd0716eb199963ec63fcafa94699d14bbf45e01.zip
binutils-1cd0716eb199963ec63fcafa94699d14bbf45e01.tar.gz
binutils-1cd0716eb199963ec63fcafa94699d14bbf45e01.tar.bz2
Move allocate_stub_method to stabsread.c
allocate_stub_method is only called from stabsread.c, and I don't think it will be needed anywhere else. So, move it and make it static. Tested by rebuilding.
-rw-r--r--gdb/gdbtypes.c20
-rw-r--r--gdb/gdbtypes.h2
-rw-r--r--gdb/stabsread.c20
3 files changed, 20 insertions, 22 deletions
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 3cdde29..cfd0a1b 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -861,26 +861,6 @@ lookup_methodptr_type (struct type *to_type)
return mtype;
}
-/* Allocate a stub method whose return type is TYPE. This apparently
- happens for speed of symbol reading, since parsing out the
- arguments to the method is cpu-intensive, the way we are doing it.
- So, we will fill in arguments later. This always returns a fresh
- type. */
-
-struct type *
-allocate_stub_method (struct type *type)
-{
- struct type *mtype;
-
- mtype = alloc_type_copy (type);
- mtype->set_code (TYPE_CODE_METHOD);
- mtype->set_length (1);
- mtype->set_is_stub (true);
- mtype->set_target_type (type);
- /* TYPE_SELF_TYPE (mtype) = unknown yet */
- return mtype;
-}
-
/* See gdbtypes.h. */
bool
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index c4889a4..52475d5 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -2312,8 +2312,6 @@ extern void smash_to_memberptr_type (struct type *, struct type *,
extern void smash_to_methodptr_type (struct type *, struct type *);
-extern struct type *allocate_stub_method (struct type *);
-
extern const char *type_name_or_error (struct type *type);
struct struct_elt
diff --git a/gdb/stabsread.c b/gdb/stabsread.c
index e159790..73f05c4 100644
--- a/gdb/stabsread.c
+++ b/gdb/stabsread.c
@@ -1464,6 +1464,26 @@ error_type (const char **pp, struct objfile *objfile)
}
+/* Allocate a stub method whose return type is TYPE. This apparently
+ happens for speed of symbol reading, since parsing out the
+ arguments to the method is cpu-intensive, the way we are doing it.
+ So, we will fill in arguments later. This always returns a fresh
+ type. */
+
+static struct type *
+allocate_stub_method (struct type *type)
+{
+ struct type *mtype;
+
+ mtype = alloc_type_copy (type);
+ mtype->set_code (TYPE_CODE_METHOD);
+ mtype->set_length (1);
+ mtype->set_is_stub (true);
+ mtype->set_target_type (type);
+ /* TYPE_SELF_TYPE (mtype) = unknown yet */
+ return mtype;
+}
+
/* Read type information or a type definition; return the type. Even
though this routine accepts either type information or a type
definition, the distinction is relevant--some parts of stabsread.c